From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 7A8A63858D20; Thu, 4 May 2023 23:25:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A8A63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1a516fb6523so10062505ad.3; Thu, 04 May 2023 16:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683242728; x=1685834728; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HIt0mk3eTwC3gjCuwuqlsEvhcwIXEiHkIQaJKr+yWJ0=; b=LeRxBqfCpXYAf06ADN1i2nj23vMaRCXiNuKZ8PkTlOl36JT91sTpr9qToZR9f4ungn lR7sTh7KNebbKrndqvtuE4Oq8t3SyuczG6QReAYqtyhbamSBwErWP7zqeb5ulU8WKaMa WidBdIIRuUv13lHXAux2hPwPrmqK4CrBoCSc3wPIstxOwMkZWByCYb0bNYeQMHB5wiYf PZrGktaTrX4jt2b+vWgeLkTusF6QbZuOeuSFpHgwaWHlNI7AT3FwbW4FRZFf+e4FSQgC bJwC89YWVPDpWKoan7RCt6x0sSY/mfi33FwnwCG6nWVMoSJQVPGVxhA1l7KlQw3MaKyW u6pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683242728; x=1685834728; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HIt0mk3eTwC3gjCuwuqlsEvhcwIXEiHkIQaJKr+yWJ0=; b=UrB4JtG1LWChvSeGYIOcB+yjW/P9s4/xQst7vH2lXce3KWiXS17Fi34IRFIZeNoDpz O2PTz983Wk5FMD5RWOnbNAk5FQkc2Y/65LfhKKBTSDpI+3uv6eyROvpusQnyLsKKivuT A4kwS7JvX5fMK3bWPoIPHZEKW+kZqtD2v9E0A24ZIYlEirI8Z0ux4Nvz6AGF2tWFKL1y eSnswepImh5iMmP1S4i6CSAHXXm/6Td+ooM8UeF2eEn3Fk58+wQWqvwfARj2rOZbKt2C yvR8tqNILrD9SEgcEf0tCGUuNAcXXEJNPwhN9ZdpbsyXYEfksjb94ZxXm+/0spnloYQ1 dk5g== X-Gm-Message-State: AC+VfDzl9fJXV+BO3DStKE3uPW/yz87vgPOqk498PfBq6tGl8XXYyw2w 44gzDy+nuJ5Fts/fA7IGQjE= X-Google-Smtp-Source: ACHHUZ6kk1gxLp0FhuYNQBNuMHSh6CH9224/Us2rXfy2PMrkM6Kru+M3zxh21u+H0PSDmeznXIOqmg== X-Received: by 2002:a17:902:ba8c:b0:1a6:fe25:4138 with SMTP id k12-20020a170902ba8c00b001a6fe254138mr4329056pls.59.1683242728122; Thu, 04 May 2023 16:25:28 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id t7-20020a170902a5c700b001a96496f250sm104966plq.34.2023.05.04.16.25.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 16:25:27 -0700 (PDT) Message-ID: <3e9d9ec2-e2ba-fefa-6a84-8cd783e162de@gmail.com> Date: Thu, 4 May 2023 17:25:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 5/5] match.pd: Use splits in makefile and make configurable. Content-Language: en-US To: Tamar Christina , Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" Cc: nd , "bonzini@gnu.org" , "neroden@gcc.gnu.org" , "aoliva@gcc.gnu.org" , "Ralf.Wildenhues@gmx.de" References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/4/23 03:56, Tamar Christina wrote: >> -----Original Message----- >> From: Kyrylo Tkachov >> Sent: Wednesday, May 3, 2023 4:19 PM >> To: Tamar Christina ; Jeff Law >> ; gcc-patches@gcc.gnu.org >> Cc: nd ; bonzini@gnu.org; neroden@gcc.gnu.org; >> aoliva@gcc.gnu.org; Ralf.Wildenhues@gmx.de >> Subject: RE: [PATCH 5/5] match.pd: Use splits in makefile and make >> configurable. >> >> >> >>> -----Original Message----- >>> From: Gcc-patches >> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Tamar >>> Christina via Gcc-patches >>> Sent: Tuesday, May 2, 2023 8:08 AM >>> To: Jeff Law ; gcc-patches@gcc.gnu.org >>> Cc: nd ; bonzini@gnu.org; neroden@gcc.gnu.org; >>> aoliva@gcc.gnu.org; Ralf.Wildenhues@gmx.de >>> Subject: RE: [PATCH 5/5] match.pd: Use splits in makefile and make >>> configurable. >>> >>>> -----Original Message----- >>>> From: Jeff Law >>>> Sent: Sunday, April 30, 2023 8:46 PM >>>> To: Tamar Christina ; >>>> gcc-patches@gcc.gnu.org >>>> Cc: nd ; bonzini@gnu.org; neroden@gcc.gnu.org; >>>> aoliva@gcc.gnu.org; Ralf.Wildenhues@gmx.de >>>> Subject: Re: [PATCH 5/5] match.pd: Use splits in makefile and make >>>> configurable. >>>> >>>> >>>> >>>> On 4/28/23 04:44, Tamar Christina via Gcc-patches wrote: >>>>> Hi All, >>>>> >>>>> This updates the build system to split up match.pd files into chunks of >> 10. >>>>> This also introduces a new flag --with-matchpd-partitions which >>>>> can be used to change the number of partitions. >>>>> >>>>> For the analysis of why 10 please look at the previous patch in the series. >>>>> >>>>> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. >>>>> >>>>> Ok for master? >>>>> >>>>> Thanks, >>>>> Tamar >>>>> >>>>> gcc/ChangeLog: >>>>> >>>>> PR bootstrap/84402 >>>>> * Makefile.in (NUM_MATCH_SPLITS, MATCH_SPLITS_SEQ, >>>>> GIMPLE_MATCH_PD_SEQ_SRC, GIMPLE_MATCH_PD_SEQ_O, >>>>> GENERIC_MATCH_PD_SEQ_SRC, GENERIC_MATCH_PD_SEQ_O): New. >>>>> (OBJS, MOSTLYCLEANFILES, .PRECIOUS): Use them. >>>>> (s-match): Split into s-generic-match and s-gimple-match. >>>>> * configure.ac (with-matchpd-partitions, >>>>> DEFAULT_MATCHPD_PARTITIONS): New. >>>>> * configure: Regenerate. >>>> This looks pretty reasonable to me. Are there any patches left in >>>> this series that need review? I'm very much looking forward to >>>> build time provements related to this patch, particularly for >>>> targets that I bootstrap with qemu emulation -- we take multiple >>>> hours to build gimple-match and the ability to parallelize those component >> builds should be a significant win. >>> >>> Hi, >>> >>> No this is the last one, Richi already approved the rest but he didn't >>> feel he had enough knowledge about the build system to say if this >>> code was portable enough. >> >> I'm looking forward to this going as well for improved bootstrap times, thanks >> for working on this! >> >>> >>> So just waiting on this one and can commit the series. >> >> Can we treat Jeff's LGTM above as an ok given his global reviewer position? > > Ah I didn't treat it as such as it wasn't in reply to the "ok for master" part. But > perhaps I misunderstood. In case it wasn't, this is also a PING for the *.in files > maintainers. My message was a fairly ambiguous. I just gave it another once over and I'll give an explicit OK for the trunk. Jeff