From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix -fsanitize=address -fstack-protector* (PR sanitizer/88333)
Date: Wed, 05 Dec 2018 03:19:00 -0000 [thread overview]
Message-ID: <3eb677ff-ae9f-a20a-f5ad-ce80373c960d@redhat.com> (raw)
In-Reply-To: <20181204233223.GE12380@tucnak>
On 12/4/18 4:32 PM, Jakub Jelinek wrote:
> Hi!
>
> The current asan.c code requires that the whole block of vars starts and
> ends on ASAN_RED_ZONE_SIZE (i.e. 32 byte) boundary, so that it is on 4 byte
> boundary in the shadow memory. Normally it is, when frame_offset starts at
> 0, but with -fstack-protector there is the guard above it and in that case
> following patch is needed to realign the end of the block.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2018-12-04 Jakub Jelinek <jakub@redhat.com>
>
> PR sanitizer/88333
> * cfgexpand.c (expand_stack_vars): If asan_vec is empty, start with
> aligning frame offset to ASAN_RED_ZONE_SIZE bytes.
>
> * c-c++-common/asan/pr88333.c: New test.
OK
jeff
prev parent reply other threads:[~2018-12-05 3:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 23:32 Jakub Jelinek
2018-12-05 3:19 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eb677ff-ae9f-a20a-f5ad-ce80373c960d@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).