From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5526 invoked by alias); 5 Dec 2018 03:19:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5482 invoked by uid 89); 5 Dec 2018 03:19:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:813 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Dec 2018 03:19:55 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB6403DBE5; Wed, 5 Dec 2018 03:19:53 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-27.rdu2.redhat.com [10.10.112.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18A6260478; Wed, 5 Dec 2018 03:19:52 +0000 (UTC) Subject: Re: [PATCH] Fix -fsanitize=address -fstack-protector* (PR sanitizer/88333) To: Jakub Jelinek , Richard Biener Cc: gcc-patches@gcc.gnu.org References: <20181204233223.GE12380@tucnak> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <3eb677ff-ae9f-a20a-f5ad-ce80373c960d@redhat.com> Date: Wed, 05 Dec 2018 03:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181204233223.GE12380@tucnak> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00251.txt.bz2 On 12/4/18 4:32 PM, Jakub Jelinek wrote: > Hi! > > The current asan.c code requires that the whole block of vars starts and > ends on ASAN_RED_ZONE_SIZE (i.e. 32 byte) boundary, so that it is on 4 byte > boundary in the shadow memory. Normally it is, when frame_offset starts at > 0, but with -fstack-protector there is the guard above it and in that case > following patch is needed to realign the end of the block. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2018-12-04 Jakub Jelinek > > PR sanitizer/88333 > * cfgexpand.c (expand_stack_vars): If asan_vec is empty, start with > aligning frame offset to ASAN_RED_ZONE_SIZE bytes. > > * c-c++-common/asan/pr88333.c: New test. OK jeff