From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 335DD3858D33 for ; Mon, 17 Jul 2023 11:55:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 335DD3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8B562F4; Mon, 17 Jul 2023 04:56:24 -0700 (PDT) Received: from [10.57.79.173] (unknown [10.57.79.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9E8E03F67D; Mon, 17 Jul 2023 04:55:40 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------6XfLVJU7BKvAXqkTWUG2RkQd" Message-ID: <3eb8505a-5fda-3f03-9463-70e045c75ceb@arm.com> Date: Mon, 17 Jul 2023 12:55:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610] Content-Language: en-US To: Jeff Law , "gcc-patches@gcc.gnu.org" Cc: "jakub@redhat.com" , Andrew Pinski References: <835f21dd-4655-fb39-6d4a-f5d954a61b94@gmail.com> From: "Andre Vieira (lists)" In-Reply-To: <835f21dd-4655-fb39-6d4a-f5d954a61b94@gmail.com> X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------6XfLVJU7BKvAXqkTWUG2RkQd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/07/2023 23:28, Jeff Law wrote: > > > On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: >> Hi, >> >> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H >> list, as insn-opinit.h is now required by internal-fn.h. This will >> lead to insn-opinit.h, among the other OPTABS_H header files, being >> installed in the plugin directory. >> >> Bootstrapped aarch64-unknown-linux-gnu. >> >> @Jakub: could you check to see if it also addresses PR 110284? >> >> >> gcc/ChangeLog: >> >>          PR 110610 >>          * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. > Why use OPTABS_H here?  Isn't the new dependency just on insn-opinit.h > and insn-codes.h and neither of those #include other headers do they? > > Yeah, there was no particular reason other than I just felt the Makefile structure sort of lend itself that way. I checked genopinit.cc and it seems insn-opinit.h doesn't include any other header files, only the sources do, so I've changed the patch to only add insn-opinit.h to INTERNAL_FN_H. ------------------- This patch fixes PR110610 by including insn-opinit.h in the INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. This will lead to insn-opinit.h, among the other OPTABS_H header files, being installed in the plugin directory. Bootstrapped aarch64-unknown-linux-gnu. gcc/ChangeLog: PR 110610 * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h. --------------6XfLVJU7BKvAXqkTWUG2RkQd Content-Type: text/plain; charset=UTF-8; name="pr110610_2.patch" Content-Disposition: attachment; filename="pr110610_2.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9NYWtlZmlsZS5pbiBiL2djYy9NYWtlZmlsZS5pbgppbmRleCBj NDc4ZWM4NTIwMTNlYWU2NWI5ZjNlYzBhNDQzZTAyM2M3ZDhiNDUyLi42ODM3NzRhZDQ0NmQ1 NDUzNjI2NDRkMmRiZGMzNzcyM2VlYTU1YmMzIDEwMDY0NAotLS0gYS9nY2MvTWFrZWZpbGUu aW4KKysrIGIvZ2NjL01ha2VmaWxlLmluCkBAIC05NzYsNyArOTc2LDcgQEAgUkVBRF9NRF9I ID0gJChPQlNUQUNLX0gpICQoSEFTSFRBQl9IKSByZWFkLW1kLmgKIEJVSUxUSU5TX0RFRiA9 IGJ1aWx0aW5zLmRlZiBzeW5jLWJ1aWx0aW5zLmRlZiBvbXAtYnVpbHRpbnMuZGVmIFwKIAln dG0tYnVpbHRpbnMuZGVmIHNhbml0aXplci5kZWYKIElOVEVSTkFMX0ZOX0RFRiA9IGludGVy bmFsLWZuLmRlZgotSU5URVJOQUxfRk5fSCA9IGludGVybmFsLWZuLmggJChJTlRFUk5BTF9G Tl9ERUYpCitJTlRFUk5BTF9GTl9IID0gaW50ZXJuYWwtZm4uaCAkKElOVEVSTkFMX0ZOX0RF RikgaW5zbi1vcGluaXQuaAogVFJFRV9DT1JFX0ggPSB0cmVlLWNvcmUuaCAkKENPUkVUWVBF U19IKSBhbGwtdHJlZS5kZWYgdHJlZS5kZWYgXAogCWMtZmFtaWx5L2MtY29tbW9uLmRlZiAk KGxhbmdfdHJlZV9maWxlcykgXAogCSQoQlVJTFRJTlNfREVGKSAkKElOUFVUX0gpIHN0YXRp c3RpY3MuaCBcCg== --------------6XfLVJU7BKvAXqkTWUG2RkQd--