public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] rs6000: Fix bootstrap (libffi)
@ 2021-10-25 23:39 Segher Boessenkool
  2021-10-27 18:44 ` H.J. Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Segher Boessenkool @ 2021-10-25 23:39 UTC (permalink / raw)
  To: gcc-patches; +Cc: dje.gcc, Segher Boessenkool

This fixes bootstrap for the current problems building libffi.

I'll work on getting this into upstream as well.  If the maintainers
want it done differently, at least we have bootstrap working again
until then.

Tested on powerpc64-linux {-m32,-m64}.


Segher


2021-10-25  Segher Boessenkool  <segher@kernel.crashing.org>

libffi/
	* src/powerpc/linux64.S: Enable AltiVec insns.
	* src/powerpc/linux64_closure.S: Ditto.
---
 libffi/src/powerpc/linux64.S         | 2 ++
 libffi/src/powerpc/linux64_closure.S | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/libffi/src/powerpc/linux64.S b/libffi/src/powerpc/linux64.S
index e92d64af34fd..1f876ea39edd 100644
--- a/libffi/src/powerpc/linux64.S
+++ b/libffi/src/powerpc/linux64.S
@@ -29,6 +29,8 @@
 #include <fficonfig.h>
 #include <ffi.h>
 
+	.machine altivec
+
 #ifdef POWERPC64
 	.hidden	ffi_call_LINUX64
 	.globl	ffi_call_LINUX64
diff --git a/libffi/src/powerpc/linux64_closure.S b/libffi/src/powerpc/linux64_closure.S
index 3469a2cbb01e..199981db3307 100644
--- a/libffi/src/powerpc/linux64_closure.S
+++ b/libffi/src/powerpc/linux64_closure.S
@@ -30,6 +30,8 @@
 
 	.file	"linux64_closure.S"
 
+	.machine altivec
+
 #ifdef POWERPC64
 	FFI_HIDDEN (ffi_closure_LINUX64)
 	.globl  ffi_closure_LINUX64
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rs6000: Fix bootstrap (libffi)
  2021-10-25 23:39 [PATCH] rs6000: Fix bootstrap (libffi) Segher Boessenkool
@ 2021-10-27 18:44 ` H.J. Lu
  2021-10-27 23:19   ` Segher Boessenkool
  0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2021-10-27 18:44 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: GCC Patches, David Edelsohn

On Mon, Oct 25, 2021 at 4:39 PM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> This fixes bootstrap for the current problems building libffi.
>
> I'll work on getting this into upstream as well.  If the maintainers
> want it done differently, at least we have bootstrap working again
> until then.
>
> Tested on powerpc64-linux {-m32,-m64}.
>
>
> Segher
>
>
> 2021-10-25  Segher Boessenkool  <segher@kernel.crashing.org>
>
> libffi/
>         * src/powerpc/linux64.S: Enable AltiVec insns.
>         * src/powerpc/linux64_closure.S: Ditto.
> ---
>  libffi/src/powerpc/linux64.S         | 2 ++
>  libffi/src/powerpc/linux64_closure.S | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/libffi/src/powerpc/linux64.S b/libffi/src/powerpc/linux64.S
> index e92d64af34fd..1f876ea39edd 100644
> --- a/libffi/src/powerpc/linux64.S
> +++ b/libffi/src/powerpc/linux64.S
> @@ -29,6 +29,8 @@
>  #include <fficonfig.h>
>  #include <ffi.h>
>
> +       .machine altivec
> +
>  #ifdef POWERPC64
>         .hidden ffi_call_LINUX64
>         .globl  ffi_call_LINUX64
> diff --git a/libffi/src/powerpc/linux64_closure.S b/libffi/src/powerpc/linux64_closure.S
> index 3469a2cbb01e..199981db3307 100644
> --- a/libffi/src/powerpc/linux64_closure.S
> +++ b/libffi/src/powerpc/linux64_closure.S
> @@ -30,6 +30,8 @@
>
>         .file   "linux64_closure.S"
>
> +       .machine altivec
> +
>  #ifdef POWERPC64
>         FFI_HIDDEN (ffi_closure_LINUX64)
>         .globl  ffi_closure_LINUX64
> --
> 1.8.3.1
>

I am checking in this patch:

https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582717.html

-- 
H.J.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rs6000: Fix bootstrap (libffi)
  2021-10-27 18:44 ` H.J. Lu
@ 2021-10-27 23:19   ` Segher Boessenkool
  0 siblings, 0 replies; 3+ messages in thread
From: Segher Boessenkool @ 2021-10-27 23:19 UTC (permalink / raw)
  To: H.J. Lu; +Cc: GCC Patches, David Edelsohn

Hi!

On Wed, Oct 27, 2021 at 11:44:59AM -0700, H.J. Lu wrote:
> On Mon, Oct 25, 2021 at 4:39 PM Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
> > This fixes bootstrap for the current problems building libffi.
> >
> > I'll work on getting this into upstream as well.  If the maintainers
> > want it done differently, at least we have bootstrap working again
> > until then.

> I am checking in this patch:
> 
> https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582717.html

Ah thanks :-)  I thought I'd get it fixed upstream soon, but that might
not happen (or not in time, etc.)  This is a good idea no matter what.


Segher

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-27 23:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 23:39 [PATCH] rs6000: Fix bootstrap (libffi) Segher Boessenkool
2021-10-27 18:44 ` H.J. Lu
2021-10-27 23:19   ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).