[committed] MAINTAINERS: Add myself as a VAX port maintainer

[committed] MAINTAINERS: Add myself as a VAX port maintainer

[Maciej W. Rozycki]

	* MAINTAINERS (CPU Port Maintainers): Add myself as a VAX port
	maintainer.
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b22f930583a..901a6305184 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -117,6 +117,7 @@ tilegx port		Walter Lee		<walt@tilera.com>
 tilepro port		Walter Lee		<walt@tilera.com>
 v850 port		Nick Clifton		<nickc@redhat.com>
 vax port		Matt Thomas		<matt@3am-software.com>
+vax port		Maciej W. Rozycki	<macro@embecosm.com>
 visium port		Eric Botcazou		<ebotcazou@libertysurf.fr>
 x86-64 port		Jan Hubicka		<hubicka@ucw.cz>
 xstormy16 port		Nick Clifton		<nickc@redhat.com>
-- 
2.11.0

Re: [committed] MAINTAINERS: Add myself as a VAX port maintainer

[Martin Liška]

On 10/26/21 17:26, Maciej W. Rozycki wrote:
> 	* MAINTAINERS (CPU Port Maintainers): Add myself as a VAX port
> 	maintainer.

Congratulations!

Please remove your name from Write After Approval:

$ make check -k RUNTESTFLAGS="maintainers.exp"
...
Running /home/marxin/Programming/gcc/gcc/testsuite/gcc.src/maintainers.exp ...
Redundant in write approval: Maciej W. Rozycki
FAIL: maintainers-verify.sh

Cheers,
Martin

> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b22f930583a..901a6305184 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -117,6 +117,7 @@ tilegx port		Walter Lee		<walt@tilera.com>
>   tilepro port		Walter Lee		<walt@tilera.com>
>   v850 port		Nick Clifton		<nickc@redhat.com>
>   vax port		Matt Thomas		<matt@3am-software.com>
> +vax port		Maciej W. Rozycki	<macro@embecosm.com>
>   visium port		Eric Botcazou		<ebotcazou@libertysurf.fr>
>   x86-64 port		Jan Hubicka		<hubicka@ucw.cz>
>   xstormy16 port		Nick Clifton		<nickc@redhat.com>
> 

Re: [committed] MAINTAINERS: Add myself as a VAX port maintainer

[Maciej W. Rozycki]

On Tue, 26 Oct 2021, Martin Liška wrote:

> Please remove your name from Write After Approval:
> 
> $ make check -k RUNTESTFLAGS="maintainers.exp"
> ...
> Running /home/marxin/Programming/gcc/gcc/testsuite/gcc.src/maintainers.exp ...
> Redundant in write approval: Maciej W. Rozycki
> FAIL: maintainers-verify.sh

 Hmm, that seems like useless policy to me; the "Write After Approval" 
section used to be an exhaustive, alphabetically sorted list of people 
with commit rights, and it still is with our sister projects binutils and 
GDB.  By removing entries for people listed elsewhere (which may be across 
several places anyway) you require one to look for information scattered 
around the file.  And contributors to remember adding themselves back as 
they step down from maintainer posts.

 Besides, my e-mail addresses listed are different in the two sections, 
and that's been deliberate.  Also what about people carrying identical 
full names?  I insist on using my middle initial for a reason.

 It seems like there's been hardly any discussion about this matter around 
the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add 
contrib/maintainers-verify.sh").  What was the actual motivation behind 
that change?

  Maciej

Re: [committed] MAINTAINERS: Add myself as a VAX port maintainer

[Jakub Jelinek]

On Tue, Oct 26, 2021 at 06:51:09PM +0100, Maciej W. Rozycki wrote:
> On Tue, 26 Oct 2021, Martin Liška wrote:
> 
> > Please remove your name from Write After Approval:
> > 
> > $ make check -k RUNTESTFLAGS="maintainers.exp"
> > ...
> > Running /home/marxin/Programming/gcc/gcc/testsuite/gcc.src/maintainers.exp ...
> > Redundant in write approval: Maciej W. Rozycki
> > FAIL: maintainers-verify.sh
> 
>  Hmm, that seems like useless policy to me; the "Write After Approval" 
> section used to be an exhaustive, alphabetically sorted list of people 
> with commit rights, and it still is with our sister projects binutils and 
> GDB.  By removing entries for people listed elsewhere (which may be across 
> several places anyway) you require one to look for information scattered 
> around the file.  And contributors to remember adding themselves back as 
> they step down from maintainer posts.
> 
>  Besides, my e-mail addresses listed are different in the two sections, 
> and that's been deliberate.  Also what about people carrying identical 
> full names?  I insist on using my middle initial for a reason.
> 
>  It seems like there's been hardly any discussion about this matter around 
> the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add 
> contrib/maintainers-verify.sh").  What was the actual motivation behind 
> that change?

That was only addition of a script and testcase to verify what has been done
in MAINTAINERS since forever.
Just look at all the commits to remove redundant entries from Write After
Approval, e.g.
https://gcc.gnu.org/legacy-ml/gcc-patches/2003-05/msg00366.html
All maintainers or reviewers (global or specific) have write after approval
rights for areas they don't maintain.

	Jakub

Re: [committed] MAINTAINERS: Add myself as a VAX port maintainer

[Jeff Law]

On 10/26/2021 1:06 PM, Jakub Jelinek via Gcc-patches wrote:
> On Tue, Oct 26, 2021 at 06:51:09PM +0100, Maciej W. Rozycki wrote:
>> On Tue, 26 Oct 2021, Martin Liška wrote:
>>
>>> Please remove your name from Write After Approval:
>>>
>>> $ make check -k RUNTESTFLAGS="maintainers.exp"
>>> ...
>>> Running /home/marxin/Programming/gcc/gcc/testsuite/gcc.src/maintainers.exp ...
>>> Redundant in write approval: Maciej W. Rozycki
>>> FAIL: maintainers-verify.sh
>>   Hmm, that seems like useless policy to me; the "Write After Approval"
>> section used to be an exhaustive, alphabetically sorted list of people
>> with commit rights, and it still is with our sister projects binutils and
>> GDB.  By removing entries for people listed elsewhere (which may be across
>> several places anyway) you require one to look for information scattered
>> around the file.  And contributors to remember adding themselves back as
>> they step down from maintainer posts.
>>
>>   Besides, my e-mail addresses listed are different in the two sections,
>> and that's been deliberate.  Also what about people carrying identical
>> full names?  I insist on using my middle initial for a reason.
>>
>>   It seems like there's been hardly any discussion about this matter around
>> the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add
>> contrib/maintainers-verify.sh").  What was the actual motivation behind
>> that change?
> That was only addition of a script and testcase to verify what has been done
> in MAINTAINERS since forever.
> Just look at all the commits to remove redundant entries from Write After
> Approval, e.g.
> https://gcc.gnu.org/legacy-ml/gcc-patches/2003-05/msg00366.html
> All maintainers or reviewers (global or specific) have write after approval
> rights for areas they don't maintain.
I went ahead and fixed Maciej's entries in the obvious way.

jeff

[PATCH] MAINTAINERS: Clarify the policy WRT the Write After Approval list

[Maciej W. Rozycki]

	* MAINTAINERS: Clarify the policy WRT the Write After Approval
	list.
---
On Tue, 26 Oct 2021, Jeff Law wrote:

> > >   It seems like there's been hardly any discussion about this matter
> > > around
> > > the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add
> > > contrib/maintainers-verify.sh").  What was the actual motivation behind
> > > that change?
> > That was only addition of a script and testcase to verify what has been done
> > in MAINTAINERS since forever.
> > Just look at all the commits to remove redundant entries from Write After
> > Approval, e.g.
> > https://gcc.gnu.org/legacy-ml/gcc-patches/2003-05/msg00366.html
> > All maintainers or reviewers (global or specific) have write after approval
> > rights for areas they don't maintain.
> I went ahead and fixed Maciej's entries in the obvious way.

 Thanks.  It did not occur to me that we had such a policy in place even 
before said commit, and now that I can see it is the case it seems to me 
like it has been a recurring problem with people not being aware of it, 
and I can hardly imagine anyone running the test suite for a MAINTAINERS 
file update.

 So while I maintain my concerns about the policy itself, how about this 
change, so that at least it's written down somewhere other than mailing 
list archives only?

  Maciej
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index fe56b2f647e..1471f53d30b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15,6 +15,9 @@ To report problems in GCC, please visit:
 
   http://gcc.gnu.org/bugs/
 
+Note: when adding someone to a more specific section please remove any
+corresponding entry from the Write After Approval list.
+
 Maintainers
 ===========
 
-- 
2.11.0

[PING][PATCH] MAINTAINERS: Clarify the policy WRT the Write After Approval list

[Maciej W. Rozycki]

On Wed, 27 Oct 2021, Maciej W. Rozycki wrote:

> 	* MAINTAINERS: Clarify the policy WRT the Write After Approval
> 	list.

 Ping for:

<https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582690.html>

  Maciej

Re: [PING][PATCH] MAINTAINERS: Clarify the policy WRT the Write After Approval list

[Jeff Law]

On 11/3/2021 8:00 AM, Maciej W. Rozycki wrote:
> On Wed, 27 Oct 2021, Maciej W. Rozycki wrote:
>
>> 	* MAINTAINERS: Clarify the policy WRT the Write After Approval
>> 	list.
>   Ping for:
>
> <https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582690.html>
OK
jeff

Re: [PING][PATCH] MAINTAINERS: Clarify the policy WRT the Write After Approval list

[Maciej W. Rozycki]

On Wed, 3 Nov 2021, Jeff Law wrote:

> > > 	* MAINTAINERS: Clarify the policy WRT the Write After Approval
> > > 	list.
> >   Ping for:
> > 
> > <https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582690.html>
> OK

 Applied now, thanks!

  Maciej