From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 262F038768A1 for ; Fri, 27 Oct 2023 19:50:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 262F038768A1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 262F038768A1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698436207; cv=none; b=M4uZ0kMSf3WkT52LerxdtZfknvbkZK5/2gAVoqqPzj9u9Tn48DiU9bPWPTspcOPly/QxhC33o9wRZYsORn4VtE20DM72SLMgvtk11xxpNfdJeGlgBUJBivNqjLMX/kJ+RD4avDelXyHKwEvf/w8IQvwH2xQd7SwADGexkqs2ReM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698436207; c=relaxed/simple; bh=nmc0EZyzUYFvoG5ey2/unwIAvCkbKcEcQwpzOCEFbmA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=w4Evb5194Illt93IFVLLhFByAyqmCCLVK/ezEk8IPpWaP4hoXc1VhXBbFAcQ8KlEo/TVzOMSINqjsP0jCax4UpJplplY5k1pkxxTjJTQ2GDjFDdZZZtADjYHj03Q7U18qDEC/QAznmtROoiLP/Ti63XsiPd+eIT6UExnHqLFqOo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1c9c5a1b87bso20096715ad.3 for ; Fri, 27 Oct 2023 12:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698436205; x=1699041005; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HhSJr5nCC68ZW0p/PqF7u3kkv7qu41CS7omlxQNCXvc=; b=FC0Wz46UHLnNSFuwvwhx1cWO/zyJrQK3q4pIyFxPsHtjJUvKg1G7rhBPalDKwuNR0V j4aV0O1OhcqvL7mIEWH9xR22PK9/z5dQq4/U8q7C0A1rlwOVDJncnyC4Ekw5LEWvJ56/ GBE3GnsCBNHF4i2QbonbxC4Yo4bDSN+iuwugXB4DExsnuXPIphhxEAU5uO4VfECQSNj2 aS8EIxJ+mCK1nwR8RjN+8MmM3NOUiv8yumApnjDMSfNgXHCNPw93LQl3trFW39HEaE21 lACfitpQlUx3AQDnW0x+Nt2813nmarQaWWW0MFV65+3SWkab1qIWZO4PbGNtkrAFJk09 4RqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698436205; x=1699041005; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HhSJr5nCC68ZW0p/PqF7u3kkv7qu41CS7omlxQNCXvc=; b=MDbYYGeZ0HY2hG7DXw9gpQWXBJs/Pq6F/7/t804ss7eupAOW+BJZXVsrDOQ1hmI/Pc Y1PZgjzxwKLOOtghSXMWGPFw6TV/c7WQqa3cK7VP1jr9hoCP/LOmmBD5ygLurOTFuJ03 9JTHUpY8S+cAGgTZeMm3jNw1dUf+wMbBsCYczO10epMuwu1rrBxBebxr0/BB60MG40BT /9s6GtR+/cSkX4LtThxZCBqWjadMCk3GzQyNDucQhKievj7ZXbAYhInjSbM8p+NK1NRi BEWWvHV4w7chztKfg7fHNesypLKEO4ufqJTtVn18FT6wQJp4vkJmIDtcDpTXI+jDy39s eyzQ== X-Gm-Message-State: AOJu0YxdLfzUYbHD+3LiRbzxd90T48cBiGEQYP2TDcgXndpOg3566N8E oTwfJnbAk4HZBwa1jVKaGcNBsHUnWlY= X-Google-Smtp-Source: AGHT+IHMD+PJDyrYpMAXBTTL1kI/mvj7XiWKJMaZENhgMeMPmFluginf6eLbRdxWurX2gAJxwqNY/A== X-Received: by 2002:a17:903:27cd:b0:1c3:ae56:4594 with SMTP id km13-20020a17090327cd00b001c3ae564594mr3751156plb.49.1698436205008; Fri, 27 Oct 2023 12:50:05 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id e3-20020a17090301c300b001c0a414695dsm1950876plh.62.2023.10.27.12.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Oct 2023 12:50:04 -0700 (PDT) Message-ID: <3f2c538f-2635-4388-b241-d61842b23cc9@gmail.com> Date: Fri, 27 Oct 2023 13:50:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gcc.c-torture/execute/builtins/fputs.c: fputs_unlocked prototype Content-Language: en-US To: Florian Weimer , gcc-patches@gcc.gnu.org References: <874jihybsu.fsf@oldenburg.str.redhat.com> From: Jeff Law In-Reply-To: <874jihybsu.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/23/23 02:37, Florian Weimer wrote: > Current glibc headers only declare fputs_unlocked for _GNU_SOURCE, > so define it to obtain an official prototype. > > Add a fallback prototype declaration for other systems that do not > have fputs_unlocked. This seems to the most straightforward approach > to avoid an implicit function declaration, without reducing test > coverage and introducing ongoing maintenance requirements (e.g.g, > FreeBSD added fputs_unlocked support fairly recently). > > gcc/testsuite/ > > * gcc.c-torture/execute/builtins/fputs.c (_GNU_SOURCE): > Define. > (fputs_unlocked): Declare. This approach is fine too. OK. jeff