From: Jeff Law <jeffreyalaw@gmail.com>
To: iain@sandoe.co.uk, gcc-patches@gcc.gnu.org
Cc: ro@CeBiTec.Uni-Bielefeld.DE
Subject: Re: [PATCH] testsuite, ubsan: Add libstdc++ deps where required.
Date: Fri, 2 Feb 2024 07:17:01 -0700 [thread overview]
Message-ID: <3f39db2b-3af2-4c94-9e91-f505049d091b@gmail.com> (raw)
In-Reply-To: <20240130103135.2005-1-iain@sandoe.co.uk>
On 1/30/24 03:31, Iain Sandoe wrote:
> tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux,
> OK for trunk?
> thanks
> Iain
>
> --- 8< ---
>
> We use the ubsan tests from both C, C++, D and Fortran.
> the sanitizer libraries link to libstdc++.
>
> When we are using the C/gdc/gfortran driver, and the target might
> require a path to the libstdc++ (e.g. for handing -static-xxxx or
> for embedded runpaths), we need to add a suitable option (or we get
> fails at execution time because of the missing paths).
>
> Conversely, we do not want to add multiple instances of these
> paths (since that leads to failures on tools that report warnings
> for duplicate runpaths).
>
> This patch modifies the _init function to allow a sigle parameter
> that determines whether the *asan_init should add a path for
> libstdc++ (yes for C driver, no for C++ driver).
> gcc/testsuite/ChangeLog:
>
> * g++.dg/ubsan/ubsan.exp:Add a parameter to init to say that
> we expect the C++ driver to provide paths for libstdc++.
> * gcc.dg/ubsan/ubsan.exp: Add a parameter to init to say that
> we need a path added for libstdc++.
> * gdc.dg/ubsan/ubsan.exp: Likewise.
> * gfortran.dg/ubsan/ubsan.exp: Likewise.
> * lib/ubsan-dg.exp: Handle a single parameter to init that
> requests addition of a path to libstdc++ to link flags.
Also OK.
jeff
prev parent reply other threads:[~2024-02-02 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:31 Iain Sandoe
2024-02-02 0:06 ` Mike Stump
2024-02-02 14:17 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f39db2b-3af2-4c94-9e91-f505049d091b@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).