From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 21CD73858D28 for ; Tue, 29 Aug 2023 02:12:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21CD73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 6545D300089; Tue, 29 Aug 2023 02:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1693275141; bh=HxZOAVvMKoBolol66ijKJAYp+MMVJQ9l06W7W5M8smY=; h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=EKVjWlABP6J5ycDBL57dUUXwvXJfCOY6+v7o4gMcOFxaPeAPce/xIxkU9luekyFat 0IBhB7UizAaSoqULNd+w+bjyu/O/PI1GZLPO3h7IuHYKTab4Hsg1emq/VHUc8vsbw+ akMRNfG5vtjVGhSACTxONzIv2D6ZJdz+a5r5SWPY= Message-ID: <3f48dab9-0d40-4c75-8b06-298e54a45740@irq.a4lg.com> Date: Tue, 29 Aug 2023 11:12:20 +0900 Mime-Version: 1.0 Subject: Re: [PATCH] RISC-V: Revive test case PR 102957 Content-Language: en-US To: Jeff Law Cc: gcc-patches@gcc.gnu.org References: <3aa13843de038d960fdb3415f416243e43b376f2.1691745095.git.research_trasio@irq.a4lg.com> <8213c477-1339-c15a-5ae2-d4a920f38f20@gmail.com> From: Tsukasa OI In-Reply-To: <8213c477-1339-c15a-5ae2-d4a920f38f20@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023/08/29 7:01, Jeff Law wrote: > > > On 8/11/23 08:29, Tsukasa OI wrote: >> On 2023/08/11 23:15, Jeff Law wrote: > >>> >> >> Originally, it tested that a two letter extension ('Zb') is accepted by >> GCC (because the background of PR 102957 was GCC assumed multi-letter >> 'Z' extensions are three letters or more). >> >> After rejecting unrecognized extensions, "dg-error" is added **just to >> avoid the test failure** and that doesn't look right.  Yes, we now don't >> have an ICE (like in the original report) but after the PR 102957 fix, >> we just accepted it, not rejecting it. >> >> Instead, we have a valid (recognized) two-letter 'Z' extension: 'Zk'.  I >> think replacing "zb" with "zk" is more correct considering the original >> bug report (PR 102957) and its assumption. >> >> cf. > Thanks.  It still seems to me we want to  have two tests here. > > I would suggest leaving pr102957.c alone since that tests that we give a > proper error for "zb".  Then create a new test that verifies "zk" is > accepted without error. > > jeff > Okay, that's a great compromise. I will make v2 to add pr102957-2.c (like so) to reflect my intention and keep the original pr102957.c. Thanks, Tsukasa