Re: [PATCH 6/7] diagnostics: eliminate diagnostic_context::m_print_path callback

[David Malcolm <dmalcolm@redhat.com>]

On Tue, 2024-06-18 at 11:08 -0400, David Malcolm wrote:
> No functional change intended.

Sorry, it looks like I should have combined patches 6 and 7, in that
patch 6 temporarily breaks the build:

e.g.:
  https://builder.sourceware.org/buildbot/#/builders/156/builds/10063

make[2]: Leaving directory '/home/mjw/wildebeest/buildbot/gcc-fedora-ppc64le/gcc-build/gcc'
g++ -no-pie   -g -O2     -DIN_GCC    -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -no-pie  gcov-dump.o \
	hash-table.o ggc-none.o\
	libcommon.a ../libcpp/libcpp.a   ../libbacktrace/.libs/libbacktrace.a ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a  -o gcov-dump
/usr/bin/ld: libcommon.a(diagnostic.o): in function `diagnostic_context::show_any_path(diagnostic_info const&)':
/home/mjw/wildebeest/buildbot/gcc-fedora-ppc64le/gcc-build/gcc/../../gcc/gcc/diagnostic.cc:918:(.text+0x2084): undefined reference to `diagnostic_context::print_path(diagnostic_path const*)'
/usr/bin/ld: /home/mjw/wildebeest/buildbot/gcc-fedora-ppc64le/gcc-build/gcc/../../gcc/gcc/diagnostic.cc:918:(.text+0x4a34): undefined reference to `diagnostic_context::print_path(diagnostic_path const*)'
collect2: error: ld returned 1 exit status

Should be fixed by patch 7 in the kit, which puts that symbol in
libcommon.a; am continuing to watch the post-commit CI.

Sorry again
Dave