From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D5E263858D38 for ; Mon, 11 Mar 2024 10:14:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5E263858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5E263858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152057; cv=none; b=ZyssNuRX50sgdlvv6Z5BVPEM4WIgIbmRitsFBBi93MCHFkmpuf0QPZWkBXKXCVEkwQjrP1Ne9pzQ6lyDjSHkUAbspgcwsZRB48KdYeUyEal0osbpTxY5ZZ7SiRd1Jw/AMNgvRiSMaRPUwvQUORp993QrBMZGmEpcn2MPmL/E8/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152057; c=relaxed/simple; bh=pMLCZbrLyeq8crr3ILI4yvvR7E7UYsX0dRCSDEjKaTM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=TWVKIRqJV5H+wQo9sFdI06libfIpzGRgpqK0zdBufCrwMoBWkB+u/+z+wBpzB5ciFsf77ZbZbLgWevg3xttGeP3gYbZxJoJFt0ntohOzi0D8+kqGpJUpE1G5oJwJRlHQewqHWmqyYrX3xGyWxke9U9ITgt5SbCSybeErMtmOlsE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42BABwdf024920 for ; Mon, 11 Mar 2024 10:14:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=NPaLWZqNg2O5aOvCk8zhBhTEmk93YlNqm8TilTCvEV4=; b=gxlFhLr98esGkrVT+IuCTZCGAiPR6LWb5xDlJYkE4SvZV6C0/KTe8Y2MZx0Ab08FJfVx pK62LrYmu1Ir9rfI1gsQC8vMgNSUtuYd5uJq9r5FP2HzRZvXc1zOebd5kvXFLxJReRb/ fJ9wtFhEefK8r4pyIjmhpMEyNVY4IBnYQXkELyDdjJ53IHfM2j50wRkI79mEd3AHj/Nr y3rfivKt5PgGmEKZ3hxn6OtAsD+aArUAzed8WMTpyNYmKyiuJraE5K/ZLst7sWAgw2Sr FNifh9lVu38TvQc75DLQWbE9scmm4j2lfaLjht82dRnwG9nVDHHeWJMdq/Bq1PI+B9mz zA== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wt009g293-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Mar 2024 10:14:11 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42B9jerY015501 for ; Mon, 11 Mar 2024 10:14:10 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ws2fyg0sd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Mar 2024 10:14:10 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42BAE4o435914098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2024 10:14:06 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A107E20077; Mon, 11 Mar 2024 10:14:04 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 775732004E; Mon, 11 Mar 2024 10:14:04 +0000 (GMT) Received: from [9.171.93.116] (unknown [9.171.93.116]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 11 Mar 2024 10:14:04 +0000 (GMT) Message-ID: <3f6a2bd4-d44c-466f-ae49-efe782cb5c7c@linux.ibm.com> Date: Mon, 11 Mar 2024 11:14:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] s390: Fix test vector/long-double-to-i64.c Content-Language: en-US To: Stefan Schulze Frielinghaus , gcc-patches@gcc.gnu.org References: <20240229121504.1200327-1-stefansf@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <20240229121504.1200327-1-stefansf@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ceQzAMYuIGpuaqG6csYAAveWgnuBpPjd X-Proofpoint-ORIG-GUID: ceQzAMYuIGpuaqG6csYAAveWgnuBpPjd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-11_07,2024-03-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 phishscore=0 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403110076 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/29/24 13:15, Stefan Schulze Frielinghaus wrote: > Starting with r14-8319-g86de9b66480b71 fwprop improved so that vpdi is > no longer required. > > gcc/testsuite/ChangeLog: > > * gcc.target/s390/vector/long-double-to-i64.c: Fix scan > assembler directive. Should we perhaps rather turn the scan-assembler directives into something which checks for the absence of vpdi then? In order to get notified once this really useful optimization breaks? Andreas > --- > .../gcc.target/s390/vector/long-double-to-i64.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c b/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c > index 2dbbb5d1c03..ed89878e6ee 100644 > --- a/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c > +++ b/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c > @@ -1,19 +1,24 @@ > /* { dg-do compile } */ > /* { dg-options "-O3 -march=z14 -mzarch --save-temps" } */ > /* { dg-do run { target { s390_z14_hw } } } */ > +/* { dg-final { check-function-bodies "**" "" "" { target { lp64 } } } } */ > + > #include > #include > > +/* > +** long_double_to_i64: > +** ld %f0,0\(%r2\) > +** ld %f2,8\(%r2\) > +** cgxbr %r2,5,%f0 > +** br %r14 > +*/ > __attribute__ ((noipa)) static int64_t > long_double_to_i64 (long double x) > { > return x; > } > > -/* { dg-final { scan-assembler-times {\n\tvpdi\t%v\d+,%v\d+,%v\d+,1\n} 1 } } */ > -/* { dg-final { scan-assembler-times {\n\tvpdi\t%v\d+,%v\d+,%v\d+,5\n} 1 } } */ > -/* { dg-final { scan-assembler-times {\n\tcgxbr\t} 1 } } */ > - > int > main (void) > {