From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 66CFC3858CDB for ; Sun, 2 Apr 2023 19:54:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66CFC3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id om3-20020a17090b3a8300b0023efab0e3bfso30473880pjb.3 for ; Sun, 02 Apr 2023 12:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680465278; x=1683057278; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WZmFhBl0jX1AqffzqGwH8NkNvn50x8q5PDCX1IhK5JQ=; b=J5k3IBVuBWJtkePS4igPgKX5QsTGOp480dwwIljofGHlrv++4I1Ou+3Ro8+T0apFOL skhsyakhZ4DiDZky0V1qMFJ0Zk/Y2Es970Zrc9W2fC2rxzPAyKQLLJLwe3EsoeaSwRgc 6KdHZDXIUINuxh4d1Wjd4pgprYugnjZLidez2Tm4jZPOkty5xI1mWlL5mdxs3WGrL14Q K6d3LSzlbDPbO2u4gf37VAuIV3pCpPaXJQGgDLrDCi0XP3tOYBpO5UfD/3Ii3JugbWo2 X+0Ml71/rohrElZxYpTuD+x+BKQhnoEAPFBWqzBt/ybvxM4j2blOsebGk8nOaX4MnehQ kSJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680465278; x=1683057278; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WZmFhBl0jX1AqffzqGwH8NkNvn50x8q5PDCX1IhK5JQ=; b=4wGqbsCmbnwuH0I0WwSGUsOdvK+0mOSnCBHni+A9Fzi2rk19DXQku9oEAszexu2ItI OfcS6ndjmSVpLGUKHIuVwNTGfSclIeADbdj04/mFqjLgXvmT6qBavOSY7kZrGYANkVat GK246bZ/YFFqTfbOSPpiHkUY5qS/SPbmr9tq5sEzz3P0v6Irw1OD0Bl9fN+JBZLoG6hz FNIaiy/uEoy9SSf5PHoTg0yQR6HIZeC5/b0dy15T7ZgzUvdhX/9tELRDDImPCZXq5I3c GB/AzguzpG4We8KJzOpnyTvaGv0s1106Yc3O93KV+3rQ2b4fDVoL+QsG5TUxRr2XFva0 UmYw== X-Gm-Message-State: AAQBX9cXHt1UKxCaYN8mn97kD+Trjq7V04eN5qeoz8WvpAJA8I1K/SUC i+FVdRXQfnYDIFrNIpqk8wI= X-Google-Smtp-Source: AKy350ZT3nKIuIucbTkwme3GEfobR4qP6ai9GrljiEUC+hAK2T7h47LEJJ+Ft+C4+9Eiakkc2vc8ug== X-Received: by 2002:a17:902:cad5:b0:1a1:c98c:bd4d with SMTP id y21-20020a170902cad500b001a1c98cbd4dmr27591841pld.38.1680465278181; Sun, 02 Apr 2023 12:54:38 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id w11-20020a1709027b8b00b0019c901b35ecsm5132500pll.106.2023.04.02.12.54.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Apr 2023 12:54:37 -0700 (PDT) Message-ID: <3fafb10d-3dcd-9e2e-9567-88f1817cbcd9@gmail.com> Date: Sun, 2 Apr 2023 13:54:36 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping) Content-Language: en-US To: Sam James , Kito Cheng Cc: "juzhe.zhong@rivai.ai" , gcc-patches , palmer , andrew , Jim Wilson References: <20230314002354.367655-1-sam@gentoo.org> <20230314002354.367655-2-sam@gentoo.org> <87mt3syd2y.fsf@gentoo.org> From: Jeff Law In-Reply-To: <87mt3syd2y.fsf@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/31/23 12:44, Sam James wrote: > > Kito Cheng writes: > >> It's not the RISC-V part, so this requires a global maintainer there I think? >> > > Someone able to look at the system.h bit? It should be trivial, there's > no uses left and it was added purely for a bug like this in the past > (see commit message). You assert that pthread.h is no longer used... But ISTM you really need to go back to when the include was added, understand why it was added and explain why it is no longer needed. Additionally, we're in a "regression fixes only" stage in our development cycle. As far as I can tell this does not fix a regression and is thus going to be deferred to gcc-14 unless you have a compelling reason why it needs to change now. Jeff