From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 3E45C3858C2D for ; Mon, 27 Nov 2023 18:18:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E45C3858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E45C3858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701109146; cv=none; b=HdZFbqrMAo9L2VlxCIjIyDD9XFofbSPIG5v5jx5W+XCkqq/F3d0P7vunNoWzp+XWS0MMSxkRqn6Zay1G55n0uvsYf/RshXH0Aj0mecNUFB3m1/73T5waRTqVK0HZSFqb7ESzAjmDZnf0t4pLybnkI1a3l/ukiarO/PdFNe4MOfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701109146; c=relaxed/simple; bh=upMEnAOGIx2XgAZ0gM1kYXvE4fPvPdBlthSSCLJmoUY=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=mIPUAsov+JqDUQ+MjGwjeOYsHQJ74kgNaDXeLsFvvNB0bR5Eavwh+oynVBnr7vUncS0W1EFaoxyeuOFx+ar5ECyijSwTWYU1eCbFB7URT/Et8erjXiX3KwBbSwlIEBc4bGLQjTF4Kfz9lvgTS8fHnYithYbHargy5iQAnQO+CxU= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 8+4HaXW8TAK/bmPEWEShMw== X-CSE-MsgGUID: FtUKpGD6TnOe+SmXyEK8yA== X-IronPort-AV: E=Sophos;i="6.04,231,1695715200"; d="scan'208";a="26915374" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 27 Nov 2023 10:18:57 -0800 IronPort-SDR: a8fAzRETZk93nUJjKCJXueQWHDrqnTEeYys91vUXiM1rCRLBNWwFQIC+rXanzTbDHYTMEeQFcg hfdDDjkr+9zKJVeLteitpyaWxpdOcys2oXqUbLdzhwxctqbDW47gth88DInJa5Pnar/LQbAtp6 f7TuHj0YuosvXjWwT26UzZdyK28Arhkmd1/ySB+HtIMtwPpreLpiKbxyRPycmJdxZTTMwippl1 LN/FUG0xO+IiI5djkYb3EjowSulxjvRknq/XDiMsIHrd6nBt7Ckz3+EfcahYhb2m4uFSaG+5m3 tfQ= Message-ID: <3fd0695b-a521-43af-9c5a-2ea15723c5dd@codesourcery.com> Date: Mon, 27 Nov 2023 19:18:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 3/3] OpenMP: Use enumerators for names of trait-sets and traits Content-Language: en-US From: Tobias Burnus To: Sandra Loosemore , CC: , References: <20231119092151.1690294-1-sandra@codesourcery.com> <20231122162233.1721224-1-sandra@codesourcery.com> <7913e015-6eb6-44d5-bea1-39282c4039ed@codesourcery.com> In-Reply-To: <7913e015-6eb6-44d5-bea1-39282c4039ed@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.11.23 18:19, Tobias Burnus wrote: >> + { "unified_address", >> + (1 << OMP_TRAIT_SET_IMPLEMENTATION), >> + OMP_TRAIT_PROPERTY_NONE, true, >> + NULL >> + }, > > I don't understand this code. This looks as if "requires" and > "unified_address" > are on the same level but in my understanding they have to be used as in: > > match(implementation =3D {requires(unified_address, > atomic_default_mem_order_properties(release)}) > > while from the syntax, it looks as if this would permit: > > match(implementation =3D {unified_address, > atomic_default_mem_order_properties(release)) Sandra pointed me to the spec: OpenMP 5.0 only permits the latter, i.e. using the clause names of 'requires' directly. Since OpenMP 5.1, this use is deprecated (removed in TR11/TR12) - in favor of the first syntax, i.e. using them as argument to 'requires()'. Thus, the code is fine. =E2=80=94 And shows all the joy needing to read mul= tiple spec versions at the same time without getting confused. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955