From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by sourceware.org (Postfix) with ESMTPS id CDBB2388981B for ; Sun, 19 Nov 2023 18:26:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDBB2388981B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDBB2388981B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418405; cv=none; b=CUsMYpuwKAzVBEyEy1Uojioj0UKGK/h+oJj+cJUFOxOXs7Me+5uz7r4wMIXSM5ydzw/NVdc9F2FHQdNs2XspjH/bw+yi476g8jAOrQRdwpNUnj93iZ4QT2aUdcsuAjnG+qRMp/WwoD8/vFuTchB7WFXBHFroj3iqkJl/Wkg74Lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418405; c=relaxed/simple; bh=Hq2MevKEqnwMIZHbZarwbltlqOPmpo0xCfwcBZjarxo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cGAjTUaGVV+zdtwIySclXTPwDoqPjHjJqLVBvjjoK/gN9V/GcpUxaYIh7ElN9IBZGru4j3aTWg9yewDNB122O+2AiKvbwL2t2/7e9EU/+9brKtmOk0++OeOLbAGzeaeuSm4jtnkkBbk1BuboVR0OYBP+vAfHblc3W7KAmqD2h3k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-1f48ad1700aso1834835fac.1 for ; Sun, 19 Nov 2023 10:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700418404; x=1701023204; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ObVctHMMRD3YNvmdo8C2ZAbCG6jl0Hk4roa6mWlaaaI=; b=dbBJk3UTRn/+WnuoYYw7w6x9Wer7Xp52m0mcAb+I0UzfZ3zt6UF4Ob9EXvNE++sPdY qYpXgLOCFX29+EpeNr5wOuWfRULeYdhRmwxwSAT5RB4JYw7RZ6qjnETrYM05BK4asn3p /sr7189dnT1XorIo90bXuDJCeXtPcf7B8hVjz1pt3CLITcSBy/xlNw50whXjvkNgspMI 5ZRGD/ZQ+C/vrZ6Kmg/OuDX7BBmhH/B8TFbCc4bonpyooGtidrmNAZ9HbyeI9Ykpyxvq njYBbOe5CLJAbKT+J6n46yOOdlli720Jj8LjrjkdwkRPoQMRLNEtaseZQ3k/THE5jrYf rf0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700418404; x=1701023204; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ObVctHMMRD3YNvmdo8C2ZAbCG6jl0Hk4roa6mWlaaaI=; b=quv7yv0SY4o0jiGZ6po10w8WNg0ej5LURK52FvV3w/qA9IlnU9fD3pbgA06k043j2B x8tgCI3sK+uBB9dkkdu7bI4IzC+bP0x2zO7AqU+Ys6HntdXUzAvWPEnPsNR5CLnWbcpy JCki0BNQ2XGjNhlJlQtN4EfOV+y56aXonDQyJ4RrLetpXio/nqlJnHTilTLfaSYQTUz9 E5SNwfNq3lF2lgIeAPE+YmB5apY1Pn6HNrpmwrVfv7YppvTNnLHCygsraph7thbLHnSW TUYqkvpteJHt0wraFonOX88r7Cry/QAiHYh4VmGfAtBAjdoav2yolY245sElF7Q8qzeT 2b7Q== X-Gm-Message-State: AOJu0YzruzEZzFOi8M7wIZXf38KePu0tqxcN9HomZIFnxFH52OrOjnDk b1iTGOqui5UDw1+RATOUsN7LAuddbWjEdQ== X-Google-Smtp-Source: AGHT+IEMdGFANaAMgaKIGQtJIODcuUtQsLk8xuQw5UXH//r9R3lY4apioM6+aSCk5Ppl+10pZ2Xgeg== X-Received: by 2002:a05:6871:88a:b0:1e9:dfc3:1e6c with SMTP id r10-20020a056871088a00b001e9dfc31e6cmr5792728oaq.28.1700418404095; Sun, 19 Nov 2023 10:26:44 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id ef53-20020a0568701ab500b001efb3910402sm1082217oab.0.2023.11.19.10.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 10:26:43 -0800 (PST) Message-ID: <3fd192cb-1cf7-4d90-a3f8-b7f2bb1ad76a@gmail.com> Date: Sun, 19 Nov 2023 11:26:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 32/44] RISC-V: Only use SUBREG if applicable in `riscv_expand_float_scc' Content-Language: en-US To: "Maciej W. Rozycki" , gcc-patches@gcc.gnu.org Cc: Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/23 22:42, Maciej W. Rozycki wrote: > A subsequent change to enable the processing of conditional moves on a > floating-point condition by `riscv_expand_conditional_move' will cause > `riscv_expand_float_scc' to be called for word-mode target RTX with RV64 > targets. In that case an invalid insn such as: > > (insn 25 24 0 (set (reg:DI 141) > (subreg:SI (reg:DI 143) 0)) -1 > (nil)) > > would be produced, which would crash the compiler later on. Since the > output operand of the SET operation to be produced already has the same > mode as the input operand does, just omit the use of SUBREG and assign > directly. > > gcc/ > * config/riscv/riscv.cc (riscv_expand_float_scc): Suppress the > use of SUBREG if the conditional-set target is word-mode. OK jeff