public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
	Richard Biener <rguenther@suse.de>
Subject: vect: Don't pattern match BITFIELD_REF's of non-integrals [PR107226]
Date: Wed, 12 Oct 2022 18:29:02 +0100	[thread overview]
Message-ID: <3fd8eef5-213d-23bd-4bcd-de7157d2de18@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Hi,

The original patch supported matching the 
vect_recog_bitfield_ref_pattern for
BITFIELD_REF's where the first operand didn't have a INTEGRAL_TYPE_P type.
That means it would also match vectors, leading to regressions in 
targets that
supported vectorization of those.

Bootstrappend and regression tested on aarch64-none-linux-gnu and 
x86_64-pc-linux-gnu.

gcc/ChangeLog:

         PR tree-optimization/107226
         * tree-vect-patterns.cc (vect_recog_bitfield_ref_pattern): Reject
         BITFIELD_REF's with non integral typed first operands.

[-- Attachment #2: PR107226.patch --]
[-- Type: text/plain, Size: 1774 bytes --]

diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc
index 0cc315d312667c05a27df4cdf435f0d0e6fd4a52..6afd57a50c4bcb5aec7ccca6e5dc069caa4a5a30 100644
--- a/gcc/tree-vect-patterns.cc
+++ b/gcc/tree-vect-patterns.cc
@@ -1913,6 +1913,7 @@ vect_recog_bitfield_ref_pattern (vec_info *vinfo, stmt_vec_info stmt_info,
     return NULL;
 
   if (!INTEGRAL_TYPE_P (TREE_TYPE (bf_ref))
+      || !INTEGRAL_TYPE_P (TREE_TYPE (container))
       || TYPE_MODE (TREE_TYPE (container)) == E_BLKmode)
     return NULL;
 
@@ -1921,25 +1922,7 @@ vect_recog_bitfield_ref_pattern (vec_info *vinfo, stmt_vec_info stmt_info,
   tree ret = gimple_assign_lhs (first_stmt);
   tree ret_type = TREE_TYPE (ret);
   bool shift_first = true;
-  tree vectype;
-
-  /* If the first operand of the BIT_FIELD_REF is not an INTEGER type, convert
-     it to one of the same width so we can perform the necessary masking and
-     shifting.  */
-  if (!INTEGRAL_TYPE_P (TREE_TYPE (container)))
-    {
-      unsigned HOST_WIDE_INT container_size =
-	tree_to_uhwi (TYPE_SIZE (TREE_TYPE (container)));
-      tree int_type = build_nonstandard_integer_type (container_size, true);
-      pattern_stmt
-	= gimple_build_assign (vect_recog_temp_ssa_var (int_type),
-			       VIEW_CONVERT_EXPR, container);
-      vectype = get_vectype_for_scalar_type (vinfo, int_type);
-      container = gimple_assign_lhs (pattern_stmt);
-      append_pattern_def_seq (vinfo, stmt_info, pattern_stmt, vectype);
-    }
-  else
-    vectype = get_vectype_for_scalar_type (vinfo, TREE_TYPE (container));
+  tree vectype = get_vectype_for_scalar_type (vinfo, TREE_TYPE (container));
 
   /* We move the conversion earlier if the loaded type is smaller than the
      return type to enable the use of widening loads.  */

             reply	other threads:[~2022-10-12 17:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 17:29 Andre Vieira (lists) [this message]
2022-10-13  8:15 ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fd8eef5-213d-23bd-4bcd-de7157d2de18@arm.com \
    --to=andre.simoesdiasvieira@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).