From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2DDEC3858D28 for ; Sat, 10 Jun 2023 20:30:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DDEC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686429033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7lFABSJh7rAACjGmWQoe7alVLa/ynUlyNpOn4IoVYik=; b=P1YV3jKubRCa8Fy5s2/x8gDrFUahIs7cxXos1XUqiDzIfzL6D4zn4WDGLD+xB9fWgIv1H3 ckdLjYammQJp4Q7CVIsdPocnHp5ZKldthYqa6H/0L7Wy89OtwKVVr3Hb/7mOm1Hh0dVlyV uMglT7L5V3vCFYiCjD9pG3LuMFMRGq4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-H_W97qRxMA6ThqWHL4DMsQ-1; Sat, 10 Jun 2023 16:30:32 -0400 X-MC-Unique: H_W97qRxMA6ThqWHL4DMsQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f7ecc15771so13122775e9.1 for ; Sat, 10 Jun 2023 13:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686429031; x=1689021031; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7lFABSJh7rAACjGmWQoe7alVLa/ynUlyNpOn4IoVYik=; b=bHrVlvukXOawgiXYvywTBu/1Mr6+nHBqLKkINU8taCXR1CKrbl0JmtfOnybwD4+V4N /tkH8Lc/I+NpsYo5Olf+QV4C2ShXcgX9TD11qU1xAiqelmpJ0hIrD3TVhofhd9u8UQnX t7YUZzrTFXYHB5JeB9SubVt0ZbdKaIs+A13t+q53OQueSS0tOHIMd8uR9ee2vp1cw57B OMY/JCEcoiy3FbLWhCGzcj9ueZTmsWe+rocM0zMhtcju1extCp2NQYtiTFWUg9LqtiQr 1tanzgKT1DIvwUSk5eUu1zEigTEfmwliy1NLN9m+ylBJBXXdQvpg2UFSVW62vLGRdN/T 3xJw== X-Gm-Message-State: AC+VfDyGd+4Ng2jq3vOWUfI0wAINIMQyQS4qIdzIRwJWZKvAyMlbMQU0 OmMWmsYawWjzPx869iRUH+Jd48zNqWmclPnrXJrCE9Wu0zzrmHB4+DHH/cNC9kaLIqhepGwvpJc yWkeTawxjLYWGQC5Ecg== X-Received: by 2002:a05:600c:a54:b0:3f7:f4af:5fb3 with SMTP id c20-20020a05600c0a5400b003f7f4af5fb3mr6567360wmq.9.1686429031407; Sat, 10 Jun 2023 13:30:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ60w9SMNIc5SNAy7cv14UpmmYwOYHAiSzxAGgIDpmBdbAneobtVdFdeLHtFH79x5N7p/BvV9Q== X-Received: by 2002:a05:600c:a54:b0:3f7:f4af:5fb3 with SMTP id c20-20020a05600c0a5400b003f7f4af5fb3mr6567341wmq.9.1686429030640; Sat, 10 Jun 2023 13:30:30 -0700 (PDT) Received: from [192.168.1.201] ([139.47.42.170]) by smtp.gmail.com with ESMTPSA id e17-20020a05600c219100b003f18b942338sm6637077wme.3.2023.06.10.13.30.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Jun 2023 13:30:30 -0700 (PDT) Message-ID: <3feb043e-bae6-513d-247b-ed0c23d0d21a@redhat.com> Date: Sat, 10 Jun 2023 22:30:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Implement ipa_vr hashing. To: Martin Jambor , GCC patches Cc: Andrew MacLeod References: <20230522185622.537454-1-aldyh@redhat.com> <20230522185622.537454-2-aldyh@redhat.com> From: Aldy Hernandez In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/29/23 16:51, Martin Jambor wrote: > Hi, > > On Mon, May 22 2023, Aldy Hernandez via Gcc-patches wrote: >> Implement hashing for ipa_vr. When all is said and done, all these >> patches incurr a 7.64% slowdown for ipa-cp, with is entirely covered by >> the similar 7% increase in this area last week. So we get type agnostic >> ranges with "infinite" range precision close to free. > > Do you know why/where this slow-down happens? Do we perhaps want to > limit the "infiniteness" a little somehow? I addressed the slow down in another mail. > > Also, jump functions live for a long time, have you looked at how memory > hungry they become? I hope that the hashing would be good at preventing > any issues. On a side-note, the caching does help. On a (mistaken) hunch, I had played around with removing caching for everything but UNDEFINED/VARYING and zero/nonzero to simplify things, but the cache hit ratio was still surprisingly high (+80%). So good job there :-). > > Generally, I think I OK with the patches if the impact on memory is not > too bad, though I guess they depend on the one I looked at last week, so > we may focus on that one first. I'm not sure whether this was an OK for the other patches, given you approved the first patch, so I'll hold off until you give the go-ahead. Thanks. Aldy