From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55780 invoked by alias); 30 Jan 2020 14:55:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 55771 invoked by uid 89); 30 Jan 2020 14:55:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_SHORT,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 spammy=ACLE, advsimd, acle, unspecsmd X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Jan 2020 14:55:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E71CD31B; Thu, 30 Jan 2020 06:55:44 -0800 (PST) Received: from [10.2.80.62] (e120808-lin.cambridge.arm.com [10.2.80.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C4B93F68E; Thu, 30 Jan 2020 06:55:43 -0800 (PST) Subject: Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma for AArch32 AdvSIMD To: Delia Burduv , "gcc-patches@gcc.gnu.org" Cc: "nickc@redhat.com" , Richard Earnshaw , Ramana Radhakrishnan References: <1994305c-a05b-774b-15da-5f1474b7c841@arm.com> From: Kyrill Tkachov Message-ID: <3feb8c4b-2905-36c7-cd8d-270505155c9e@foss.arm.com> Date: Thu, 30 Jan 2020 15:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2020-01/txt/msg02014.txt.bz2 Hi Delia, On 1/28/20 4:44 PM, Delia Burduv wrote: > Ping. > ------------------------------------------------------------------------ > *From:* Delia Burduv > *Sent:* 22 January 2020 17:26 > *To:* gcc-patches@gcc.gnu.org > *Cc:* nickc@redhat.com ; Richard Earnshaw > ; Ramana Radhakrishnan > ; Kyrylo Tkachov > *Subject:* Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla > and vfma for AArch32 AdvSIMD > Ping. > > I have read Richard Sandiford's comments on the AArch64 patches and I > will apply what is relevant to this patch as well. Particularly, I will > change the tests to use the exact input and output registers and I will > change the types of the rtl patterns. Please send the updated patches so that someone can commit them for you once they're reviewed. Thanks, Kyrill > > On 12/20/19 6:44 PM, Delia Burduv wrote: > > This patch adds the ARMv8.6 ACLE intrinsics for vmmla, vfmab and vfmat > > as part of the BFloat16 extension. > > (https://developer.arm.com/docs/101028/latest.) > > The intrinsics are declared in arm_neon.h and the RTL patterns are > > defined in neon.md. > > Two new tests are added to check assembler output and lane indices. > > > > This patch depends on the Arm back-end patche. > > (https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01448.html) > > > > Tested for regression on arm-none-eabi and armeb-none-eabi. I don't > have > > commit rights, so if this is ok can someone please commit it for me? > > > > gcc/ChangeLog: > > > > 2019-11-12  Delia Burduv > > > >      * config/arm/arm_neon.h (vbfmmlaq_f32): New. > >        (vbfmlalbq_f32): New. > >        (vbfmlaltq_f32): New. > >        (vbfmlalbq_lane_f32): New. > >        (vbfmlaltq_lane_f32): New. > >          (vbfmlalbq_laneq_f32): New. > >        (vbfmlaltq_laneq_f32): New. > >      * config/arm/arm_neon_builtins.def (vbfmmla): New. > >            (vbfmab): New. > >            (vbfmat): New. > >            (vbfmab_lane): New. > >            (vbfmat_lane): New. > >            (vbfmab_laneq): New. > >            (vbfmat_laneq): New. > >       * config/arm/iterators.md (BF_MA): New int iterator. > >            (bt): New int attribute. > >            (VQXBF): Copy of VQX with V8BF. > >            (V_HALF): Added V8BF. > >        * config/arm/neon.md (neon_vbfmmlav8hi): New insn. > >            (neon_vbfmav8hi): New insn. > >            (neon_vbfma_lanev8hi): New insn. > >            (neon_vbfma_laneqv8hi): New expand. > >            (neon_vget_high): Changed iterator to VQXBF. > >      * config/arm/unspecs.md (UNSPEC_BFMMLA): New UNSPEC. > >            (UNSPEC_BFMAB): New UNSPEC. > >            (UNSPEC_BFMAT): New UNSPEC. > > > > 2019-11-12  Delia Burduv > > > >          * gcc.target/arm/simd/bf16_ma_1.c: New test. > >          * gcc.target/arm/simd/bf16_ma_2.c: New test. > >          * gcc.target/arm/simd/bf16_mmla_1.c: New test.