From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id C1F0F3858CDB for ; Fri, 8 Dec 2023 06:47:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1F0F3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1F0F3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702018036; cv=none; b=B+n9pDXvXfTuOTcVMIMgNSUqDLMkK9MxwFSeaOaNqZOUJEAP4BpSPP3o9ArGl22y87GVpr19jWkL+JT02/mYd97/WC0T43FPc+9g6fiAZH+0aKElYvVQS2tgKF/o5v3guA6nyuYdyXt5fn/9tV8XvtxQNKp9A6nY55iYl3gwBSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702018036; c=relaxed/simple; bh=Gsbkqw/Uet9EXAQwVQWh+vu5jbhTUnVd3JybN0B2y90=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=tp4gHrvpHUbSeF359JjbDd3g8+ifp5ZqfHhBAXE2lIp1KwQOZRLmd9RscxLIETvZbhWRxfXhjz78F9Qw+94Ir9wH1OiyDdBCs2MtR1PhAHfRxzRZ86ilT7aOrQuwiRiICP0749Bu1REjc0O/R7TFmIePhmp9HGu+iIbVmvaryzE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BE62B1FDA6; Fri, 8 Dec 2023 06:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702018033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pBpcuGdMDqdelzBcf9ezwnhFzH+fbsuB4OSkHFpHKF0=; b=JX+KMT+mNaRVej3YA0qobp2bxRZC+Bvyovo/xH9rQUHNhBFqlpA2lGp+hq5Yg9UfZ9Smp+ Fuw/pbWmcJmLGrXnolIcGPdUvKxgfZDiTFOh1KsvrrPq/wmL4LY8obpseqNhb7bMG28b2j Z/Bh4XvgM/K0GW3CGOFwKwWbPwRbKtY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702018033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pBpcuGdMDqdelzBcf9ezwnhFzH+fbsuB4OSkHFpHKF0=; b=yI9JGjxkTmUXOFud6ssynPF5pyg0GfUk/IzeodbAYHgyi2HXJie9iA2dICqKCe1HG+C9kA NNCw+skZPyeXLEBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702018033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pBpcuGdMDqdelzBcf9ezwnhFzH+fbsuB4OSkHFpHKF0=; b=JX+KMT+mNaRVej3YA0qobp2bxRZC+Bvyovo/xH9rQUHNhBFqlpA2lGp+hq5Yg9UfZ9Smp+ Fuw/pbWmcJmLGrXnolIcGPdUvKxgfZDiTFOh1KsvrrPq/wmL4LY8obpseqNhb7bMG28b2j Z/Bh4XvgM/K0GW3CGOFwKwWbPwRbKtY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702018033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pBpcuGdMDqdelzBcf9ezwnhFzH+fbsuB4OSkHFpHKF0=; b=yI9JGjxkTmUXOFud6ssynPF5pyg0GfUk/IzeodbAYHgyi2HXJie9iA2dICqKCe1HG+C9kA NNCw+skZPyeXLEBA== Date: Fri, 8 Dec 2023 07:46:16 +0100 (CET) From: Richard Biener To: Hans-Peter Nilsson cc: oliva@adacore.com, gcc-patches@gcc.gnu.org, botcazou@adacore.com, jeffreyalaw@gmail.com, ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32 In-Reply-To: <20231207163345.1A90A2041E@pchp3.se.axis.com> Message-ID: <3qno421o-1n80-8722-snnp-3nonn63rr300@fhfr.qr> References: <6f1516e7-f4be-4e13-b04c-8b5c31cae4f7@gmail.com> <20231129180047.1334620430@pchp3.se.axis.com> <20231130170910.5B7C720442@pchp3.se.axis.com> <20231201033538.87F472042C@pchp3.se.axis.com> <5ro82896-4qq5-po26-12p5-97rnnoo31p37@fhfr.qr> <20231201231831.4238420424@pchp3.se.axis.com> <198q96q6-9os5-o2ro-9559-5875n86495r2@fhfr.qr> <20231207163345.1A90A2041E@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spam-Score: -1.10 X-Spam-Flag: NO X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,comcast.net]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[adacore.com,gcc.gnu.org,gmail.com,CeBiTec.Uni-Bielefeld.DE,comcast.net]; BAYES_HAM(-3.00)[100.00%] Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -3.10 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Dec 2023, Hans-Peter Nilsson wrote: > > Date: Mon, 4 Dec 2023 12:58:03 +0100 (CET) > > From: Richard Biener > > > On Sat, 2 Dec 2023, Hans-Peter Nilsson wrote: > > > > Date: Fri, 1 Dec 2023 08:07:14 +0100 (CET) > > > > From: Richard Biener > > > > I read from your messages that the testcases pass on arm*-*-*? > > > Yes: they pass (currently XPASS) on arm-eabi and > > > arm-unknown-linux-gnueabi, default configurations. But, > > > scev-3 and -5 fail with for example -mcpu=cortex-r5 > > > > I see. As said, the testcases test for "cost" things, so that we > > "regressed" might mean we really "regressed" here. Even the x86 -m32 > > result is questionable. > > > > Of course whether using a single IV makes sense for all archs is > > unknown. > > > > Btw, if we turn the testcases into ones that are (sub-)target > > specific then we want to again use C code as input. > > > > I think at this point we've lost track and I'm juggling between > > removing the testcases or moving them to a place they succeed > > (with some specific -mcpu=?) > > > > Richard. > > So to not drop the ball(s) on this, here's a patch with your > first alternative: remove them. > > Ok? OK. Thanks, Richard. > -- >8 -- > Subject: [PATCH] testsuite: Remove gcc.dg/tree-ssa/scev-3.c -4.c and 5.c > > These tests were recently xfailed on ilp32 targets though > passing on almost all ilp32 targets (known exceptions: ia32 > and some arm subtargets). They've been changed around too > much to remain useful. > > PR testsuite/112786 > * gcc.dg/tree-ssa/scev-3.c, gcc.dg/tree-ssa/scev-4.c, > gcc.dg/tree-ssa/scev-5.c: Remove. > --- > gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 44 ----------------------- > gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 49 -------------------------- > gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 44 ----------------------- > 3 files changed, 137 deletions(-) > delete mode 100644 gcc/testsuite/gcc.dg/tree-ssa/scev-3.c > delete mode 100644 gcc/testsuite/gcc.dg/tree-ssa/scev-4.c > delete mode 100644 gcc/testsuite/gcc.dg/tree-ssa/scev-5.c > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c > deleted file mode 100644 > index beea9aed9fe9..000000000000 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c > +++ /dev/null > @@ -1,44 +0,0 @@ > -/* { dg-do compile } */ > -/* { dg-options "-O2 -fgimple -fdump-tree-ivopts" } */ > - > -int *a_p; > -int a[1000]; > - > -void __GIMPLE (ssa,startwith ("loop")) > -f (int k) > -{ > - int i; > - int * _1; > - > -__BB(2): > - i_5 = k_4(D); > - if (i_5 <= 999) > - goto __BB4; > - else > - goto __BB3; > - > -__BB(3): > - return; > - > -__BB(4): > - goto __BB5; > - > -__BB(5): > - i_12 = __PHI (__BB6: i_9, __BB4: i_5); > - _1 = &a[i_12]; > - a_p = _1; > - __MEM ((int *)&a)[i_12] = 100; > - i_9 = i_5 + i_12; > - if (i_9 <= 999) > - goto __BB6; > - else > - goto __BB3; > - > -__BB(6): > - ; > - goto __BB5; > - > -} > - > -/* Not all 32-bit systems fail this, but several do. */ > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c > deleted file mode 100644 > index a97f75f81f65..000000000000 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c > +++ /dev/null > @@ -1,49 +0,0 @@ > -/* { dg-do compile } */ > -/* { dg-options "-O2 -fgimple -fdump-tree-ivopts" } */ > - > -typedef struct { > - int x; > - int y; > -} S; > - > -int *a_p; > -S a[1000]; > - > -void __GIMPLE (ssa, startwith ("loop")) > -f (int k) > -{ > - int i; > - int * _1; > - > -__BB(2): > - i_5 = k_4(D); > - if (i_5 <= 999) > - goto __BB4; > - else > - goto __BB3; > - > -__BB(3): > - return; > - > -__BB(4): > - goto __BB5; > - > -__BB(5): > - i_12 = __PHI (__BB6: i_9, __BB4: i_5); > - _1 = &a[i_12].y; > - a_p = _1; > - __MEM ((int *)&a)[i_12].y = 100; > - i_9 = i_5 + i_12; > - if (i_9 <= 999) > - goto __BB6; > - else > - goto __BB3; > - > -__BB(6): > - ; > - goto __BB5; > - > -} > - > -/* Not all 32-bit systems fail this, but several do. */ > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c > deleted file mode 100644 > index 08f4260403c4..000000000000 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c > +++ /dev/null > @@ -1,44 +0,0 @@ > -/* { dg-do compile } */ > -/* { dg-options "-O2 -fgimple -fdump-tree-ivopts" } */ > - > -int *a_p; > -int a[1000]; > - > -void __GIMPLE (ssa,startwith ("loop")) > -f (int k) > -{ > - long long int i; > - int * _1; > - > -__BB(2): > - i_5 = (long long int) k_4(D); > - if (i_5 <= 999ll) > - goto __BB4; > - else > - goto __BB3; > - > -__BB(3): > - return; > - > -__BB(4): > - goto __BB5; > - > -__BB(5): > - i_12 = __PHI (__BB6: i_9, __BB4: i_5); > - _1 = &a[i_12]; > - a_p = _1; > - __MEM ((int *)&a)[i_12] = 100; > - i_9 = i_5 + i_12; > - if (i_9 <= 999ll) > - goto __BB6; > - else > - goto __BB3; > - > -__BB(6): > - ; > - goto __BB5; > - > -} > - > -/* Not all 32-bit systems fail this, but several do. */ > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)