From: FX <fxcoudert@gmail.com>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
ubizjak@gmail.com, ian@airs.com, fortran@gcc.gnu.org
Subject: Re: Fix libbacktrace -fPIC breakage from "Use libbacktrace in libgfortran"
Date: Mon, 24 Aug 2015 18:42:00 -0000 [thread overview]
Message-ID: <401C3C0F-065E-4172-B391-A8714BFBC3DB@gmail.com> (raw)
In-Reply-To: <201508241640.t7OGercr016460@ignucius.se.axis.com>
> You're absolutely right on both accounts. Also, the function
> body is supposed to be a function body (...) or else we get a
> nested function (i.e. foo inside main). Might as well provide
> both empty. Also fixing the ChangeLog entry. Sorry for
> goofing. (At least I had a look at config.log this time…)
That looks better :)
But I can’t approve the patch.
FX
next prev parent reply other threads:[~2015-08-24 18:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 13:19 [patch,libgfortran,toplevel] Use libbacktrace in libgfortran Uros Bizjak
2015-08-14 14:31 ` FX
2015-08-23 20:14 ` Janne Blomqvist
2015-08-23 20:59 ` FX
2015-08-23 21:27 ` Janne Blomqvist
2015-08-24 7:15 ` FX
2015-08-24 16:00 ` Fix libbacktrace -fPIC breakage from "Use libbacktrace in libgfortran" Hans-Peter Nilsson
2015-08-24 16:08 ` FX
2015-08-24 16:44 ` Hans-Peter Nilsson
2015-08-24 18:42 ` FX [this message]
2015-08-25 3:29 ` Ian Lance Taylor
2015-08-25 13:25 ` Ulrich Weigand
2015-08-25 17:09 ` Hans-Peter Nilsson
2015-08-25 17:57 ` Ulrich Weigand
2015-08-26 0:09 ` Hans-Peter Nilsson
2015-08-26 12:17 ` Ulrich Weigand
2015-08-26 12:34 ` Hans-Peter Nilsson
2015-08-26 15:37 ` [PATCH] Fix and simplify (Re: Fix libbacktrace -fPIC breakage from "Use libbacktrace in libgfortran") Ulrich Weigand
2015-08-27 4:02 ` Ian Lance Taylor
2015-08-27 13:38 ` Ulrich Weigand
2015-08-27 14:02 ` Ian Lance Taylor
2015-08-24 16:04 ` Fix libbacktrace -fPIC breakage from "Use libbacktrace in libgfortran" Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401C3C0F-065E-4172-B391-A8714BFBC3DB@gmail.com \
--to=fxcoudert@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
--cc=ian@airs.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).