From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 0F98A3864825 for ; Sun, 19 Nov 2023 18:23:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F98A3864825 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F98A3864825 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::230 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418185; cv=none; b=vLvw9vmYmzlHLYw7L7NzPBDQGqNXuFo8t/++YGkwyBR6/bXzggzvWVNfNYYUT2FAdrBk2w9O4Iu0SmWR96tgqbNVfeLIcKfxw1p+2oPblJwB7WVYscrCncewMvpJ3XA6Mx2F7913q3n0DLLWVa2+x0F+evaXc08zpmpfDwhdsho= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418185; c=relaxed/simple; bh=U1TKjcimJAqqhtlpOJST8NUV8GxjmrD7DvdXXoumqNE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kzbHAlwhGs98HNr1h1a6vujBjUVbcPkRwxXkK+YxKzx9NAfcSNgbsYnUf7dCPkA+VE5CJwDpL4KYhnsUn5Nt11iUGONerHeaVWZQNkO7emUnr+p7NqIFQazEqzUzYTlIRo4esEGbNvHSIKqqIBJvOWvkpomjS2LhN2QvX+NBsX0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3b6d88dbaa3so2521077b6e.1 for ; Sun, 19 Nov 2023 10:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700418183; x=1701022983; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FXvQZd+YwN3yFnt58vglj8mEjtaQtFYtT4QE9ALy6ys=; b=GzSqHJpMJyY5ACfF/xBJrd/nL6EIrLmCjah3oF5oKM3r4B5qQ6pPag1jy2LMjwyYGP LJcqzlGFrgZ8x7wCfzAGu55/Y6TUHEKOJAatPrcA+AtXv9cwkcO8Jl04pluYFv9dqXmE S5562fU0C9lP98rq44JN8g2V0izTtsRuJghpyGLLSE4wB0NJv2b++AZLDvBMMqeFKHcP npIKWU1Z2CKYf9O+4dX9Wpz23BqJiU+wN3fCDkYO8C09fz1yv/wM8V8P5UvzKr9CqcnI kzqhoQ22HGbziQnzusvg8TN33opLXpy6SIY8meiuwQNy2UYqJ6CgOov6+NmFQAZwekna UEeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700418183; x=1701022983; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FXvQZd+YwN3yFnt58vglj8mEjtaQtFYtT4QE9ALy6ys=; b=g8IaG+PWlQrZn6GFzdeaqXtM5qYAtEz4gMCyhMyx0y/caviEGc9FP3weGYYSJ/UCDV uGnXUidgxiXB2sve/Emwt+lTbBzSAMBiuz/5M7u/7CPg9T8u3I+nPvimgyi4dKdtshIV PzDtbPxVdXO8LzMGqjoSPCNGXwFQQjIX6Wew6myjsWoD3f+UM7QsRg3IAbbRlRZ3rikm 8ceSlAgH9ms9mpDEDv5cNOYc4QgqcACCl8DIxcQwsJCkGd86up8bvmKw93UTDo27j2Ya 7VGQsk7rgVXlvWX0ELcJHueWYI4RjsXqTtozu/QTdFlG1Gexu4JYMa+K6oVrv/IKYTgQ 4uWQ== X-Gm-Message-State: AOJu0YxawmJKhmFkcuna1yJYgFIDPkGY7XDb/jt9ycGRTSTL7QYWKXMD O6G/eZlfTMk+3cZ7Z+tjeZA= X-Google-Smtp-Source: AGHT+IEpjgcCbowDIRFnhR3aSSA3DCGHcTbpYOzvwsaRjpWYTjodQ+abCvXtP4pDnYDSDtQyYdw/rQ== X-Received: by 2002:a05:6870:392a:b0:1f5:e3db:717a with SMTP id b42-20020a056870392a00b001f5e3db717amr4718572oap.28.1700418183226; Sun, 19 Nov 2023 10:23:03 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id dt7-20020a0568705a8700b001efce0658e6sm1062048oab.39.2023.11.19.10.23.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 10:23:02 -0800 (PST) Message-ID: <401c1684-7ae4-40e5-ad7f-aab595e4a47a@gmail.com> Date: Sun, 19 Nov 2023 11:23:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 29/44] RISC-V: Add `addMODEcc' implementation for generic targets Content-Language: en-US To: "Maciej W. Rozycki" , gcc-patches@gcc.gnu.org Cc: Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/23 22:41, Maciej W. Rozycki wrote: > Provide RTL expansion of conditional-add operations for generic targets > using a suitable sequence of base integer machine instructions according > to cost evaluation by if-conversion. Use existing `-mmovcc' command > line option to enable this transformation. > > gcc/ > * config/riscv/riscv.md (addcc): New expander. Is this an improvement over what if-convert creates for a conditional add or is the goal to expose the sequence earlier in the pipeline rather than waiting for ifcvt? Either way this is fine, just questioning slightly if really improves things. I don't see any way it'd be hurting. jeff