* [patch] Add baseline for SPARC64/Linux
@ 2019-02-20 22:25 Eric Botcazou
2019-02-22 8:36 ` Eric Botcazou
0 siblings, 1 reply; 8+ messages in thread
From: Eric Botcazou @ 2019-02-20 22:25 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
Tested on SPARC64/Linux, OK for the mainline?
2019-02-20 Eric Botcazou <ebotcazou@adacore.com>
* configure.host (abi_baseline_pair): Adjust for SPARC64/Linux.
* config/abi/post/sparc64-linux-gnu: New directory.
* config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file.
* config/abi/post/sparc64-linux-gnu/32: New directory.
* config/abi/post/sparc64-linux-gnu/32/baseline_symbols.txt: New file.
--
Eric Botcazou
[-- Attachment #2: sparc64_libstdc++-v3.diff.xz --]
[-- Type: application/x-xz, Size: 28508 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] Add baseline for SPARC64/Linux
2019-02-20 22:25 [patch] Add baseline for SPARC64/Linux Eric Botcazou
@ 2019-02-22 8:36 ` Eric Botcazou
2019-02-22 20:24 ` Jonathan Wakely
0 siblings, 1 reply; 8+ messages in thread
From: Eric Botcazou @ 2019-02-22 8:36 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
> 2019-02-20 Eric Botcazou <ebotcazou@adacore.com>
>
> * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux.
> * config/abi/post/sparc64-linux-gnu: New directory.
> * config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file.
> * config/abi/post/sparc64-linux-gnu/32: New directory.
> * config/abi/post/sparc64-linux-gnu/32/baseline_symbols.txt: New file.
I can probably self-approve it as SPARC maintainer so now installed.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] Add baseline for SPARC64/Linux
2019-02-22 8:36 ` Eric Botcazou
@ 2019-02-22 20:24 ` Jonathan Wakely
2019-02-22 20:26 ` Jakub Jelinek
2019-02-22 22:19 ` Eric Botcazou
0 siblings, 2 replies; 8+ messages in thread
From: Jonathan Wakely @ 2019-02-22 20:24 UTC (permalink / raw)
To: Eric Botcazou; +Cc: libstdc++, gcc-patches
On 22/02/19 08:27 +0100, Eric Botcazou wrote:
>> 2019-02-20 Eric Botcazou <ebotcazou@adacore.com>
>>
>> * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux.
>> * config/abi/post/sparc64-linux-gnu: New directory.
>> * config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file.
>> * config/abi/post/sparc64-linux-gnu/32: New directory.
>> * config/abi/post/sparc64-linux-gnu/32/baseline_symbols.txt: New file.
>
>I can probably self-approve it as SPARC maintainer so now installed.
Sorry for the delay, I'm in a meeting all week with limited time for
patch review.
We don't usually include the __once_callable symbols in the baseline
file, are you sure it's correct to do so for sparc64-linux-gnu?
+TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
+TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] Add baseline for SPARC64/Linux
2019-02-22 20:24 ` Jonathan Wakely
@ 2019-02-22 20:26 ` Jakub Jelinek
2019-02-22 20:32 ` Jonathan Wakely
2019-02-22 22:19 ` Eric Botcazou
1 sibling, 1 reply; 8+ messages in thread
From: Jakub Jelinek @ 2019-02-22 20:26 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: Eric Botcazou, libstdc++, gcc-patches
On Fri, Feb 22, 2019 at 07:24:57PM +0000, Jonathan Wakely wrote:
> On 22/02/19 08:27 +0100, Eric Botcazou wrote:
> > > 2019-02-20 Eric Botcazou <ebotcazou@adacore.com>
> > >
> > > * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux.
> > > * config/abi/post/sparc64-linux-gnu: New directory.
> > > * config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file.
> > > * config/abi/post/sparc64-linux-gnu/32: New directory.
> > > * config/abi/post/sparc64-linux-gnu/32/baseline_symbols.txt: New file.
> >
> > I can probably self-approve it as SPARC maintainer so now installed.
>
> Sorry for the delay, I'm in a meeting all week with limited time for
> patch review.
>
> We don't usually include the __once_callable symbols in the baseline
> file, are you sure it's correct to do so for sparc64-linux-gnu?
>
> +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
> +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
It shouldn't be there on any target, as it will differ between configuring
the library with and without TLS.
Jakub
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] Add baseline for SPARC64/Linux
2019-02-22 20:26 ` Jakub Jelinek
@ 2019-02-22 20:32 ` Jonathan Wakely
2019-02-22 20:38 ` Jakub Jelinek
0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Wakely @ 2019-02-22 20:32 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Eric Botcazou, libstdc++, gcc-patches
On 22/02/19 20:43 +0100, Jakub Jelinek wrote:
>On Fri, Feb 22, 2019 at 07:24:57PM +0000, Jonathan Wakely wrote:
>> On 22/02/19 08:27 +0100, Eric Botcazou wrote:
>> > > 2019-02-20 Eric Botcazou <ebotcazou@adacore.com>
>> > >
>> > > * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux.
>> > > * config/abi/post/sparc64-linux-gnu: New directory.
>> > > * config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file.
>> > > * config/abi/post/sparc64-linux-gnu/32: New directory.
>> > > * config/abi/post/sparc64-linux-gnu/32/baseline_symbols.txt: New file.
>> >
>> > I can probably self-approve it as SPARC maintainer so now installed.
>>
>> Sorry for the delay, I'm in a meeting all week with limited time for
>> patch review.
>>
>> We don't usually include the __once_callable symbols in the baseline
>> file, are you sure it's correct to do so for sparc64-linux-gnu?
>>
>> +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
>> +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>
>It shouldn't be there on any target, as it will differ between configuring
>the library with and without TLS.
Right, that's my understanding. We get that wrong though:
config/abi/post/x86_64-linux-gnu/x32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.11/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/mips64-linux-gnu/64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/mips64-linux-gnu/32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.10/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/i386-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.10/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.11/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
config/abi/post/sparc-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] Add baseline for SPARC64/Linux
2019-02-22 20:32 ` Jonathan Wakely
@ 2019-02-22 20:38 ` Jakub Jelinek
2019-02-22 21:47 ` Jonathan Wakely
0 siblings, 1 reply; 8+ messages in thread
From: Jakub Jelinek @ 2019-02-22 20:38 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: Eric Botcazou, libstdc++, gcc-patches
On Fri, Feb 22, 2019 at 08:24:09PM +0000, Jonathan Wakely wrote:
> > > We don't usually include the __once_callable symbols in the baseline
> > > file, are you sure it's correct to do so for sparc64-linux-gnu?
> > >
> > > +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
> > > +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> >
> > It shouldn't be there on any target, as it will differ between configuring
> > the library with and without TLS.
>
> Right, that's my understanding. We get that wrong though:
Maybe it would be best to include them but if the compiler is configured
without native TLS ignore the TLS lines.
> config/abi/post/x86_64-linux-gnu/x32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/i386-solaris2.11/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/i386-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/mips64-linux-gnu/64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/mips64-linux-gnu/32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/i386-solaris2.10/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/i386-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/sparc-solaris2.10/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/sparc-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/sparc-solaris2.11/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
> config/abi/post/sparc-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
Jakub
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] Add baseline for SPARC64/Linux
2019-02-22 20:38 ` Jakub Jelinek
@ 2019-02-22 21:47 ` Jonathan Wakely
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Wakely @ 2019-02-22 21:47 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Eric Botcazou, libstdc++, gcc-patches
On 22/02/19 21:26 +0100, Jakub Jelinek wrote:
>On Fri, Feb 22, 2019 at 08:24:09PM +0000, Jonathan Wakely wrote:
>> > > We don't usually include the __once_callable symbols in the baseline
>> > > file, are you sure it's correct to do so for sparc64-linux-gnu?
>> > >
>> > > +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
>> > > +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> >
>> > It shouldn't be there on any target, as it will differ between configuring
>> > the library with and without TLS.
>>
>> Right, that's my understanding. We get that wrong though:
>
>Maybe it would be best to include them but if the compiler is configured
>without native TLS ignore the TLS lines.
That should be a pretty easy change to the tests, I'll add it to my
TODO list.
>> config/abi/post/x86_64-linux-gnu/x32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/i386-solaris2.11/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/i386-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/mips64-linux-gnu/64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/mips64-linux-gnu/32/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/i386-solaris2.10/amd64/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/i386-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/sparc-solaris2.10/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/sparc-solaris2.10/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/sparc-solaris2.11/sparcv9/baseline_symbols.txt:TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>> config/abi/post/sparc-solaris2.11/baseline_symbols.txt:TLS:4:_ZSt15__once_callable@@GLIBCXX_3.4.11
>
> Jakub
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] Add baseline for SPARC64/Linux
2019-02-22 20:24 ` Jonathan Wakely
2019-02-22 20:26 ` Jakub Jelinek
@ 2019-02-22 22:19 ` Eric Botcazou
1 sibling, 0 replies; 8+ messages in thread
From: Eric Botcazou @ 2019-02-22 22:19 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: libstdc++, gcc-patches
> Sorry for the delay, I'm in a meeting all week with limited time for
> patch review.
No problem, thanks for reviewing!
> We don't usually include the __once_callable symbols in the baseline
> file, are you sure it's correct to do so for sparc64-linux-gnu?
>
> +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
> +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
Now removed for the sake of consistency with the SPARC/Linux twin port.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-22 21:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 22:25 [patch] Add baseline for SPARC64/Linux Eric Botcazou
2019-02-22 8:36 ` Eric Botcazou
2019-02-22 20:24 ` Jonathan Wakely
2019-02-22 20:26 ` Jakub Jelinek
2019-02-22 20:32 ` Jonathan Wakely
2019-02-22 20:38 ` Jakub Jelinek
2019-02-22 21:47 ` Jonathan Wakely
2019-02-22 22:19 ` Eric Botcazou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).