From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <doko@ubuntu.com>
Received: from einhorn-mail-out.in-berlin.de (einhorn-mail-out.in-berlin.de
 [217.197.80.21])
 by sourceware.org (Postfix) with ESMTPS id 3A9883857818
 for <gcc-patches@gcc.gnu.org>; Fri,  4 Dec 2020 14:41:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3A9883857818
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=ubuntu.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=doko@ubuntu.com
X-Envelope-From: doko@ubuntu.com
Received: from authenticated.user (localhost [127.0.0.1]) by
 einhorn.in-berlin.de with ESMTPSA id 0B4EfASV019704
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);
 Fri, 4 Dec 2020 15:41:11 +0100
Subject: Re: [PATCH] RISC-V: Canonicalize --with-arch
From: Matthias Klose <doko@ubuntu.com>
To: Kito Cheng <kito.cheng@gmail.com>, Jim Wilson <jimw@sifive.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
References: <20201201081313.68385-1-kito.cheng@sifive.com>
 <CAFyWVaZgSNzpzgdMgWF4xfvAry-7OjzS3GXDTR886PmEeLhY_w@mail.gmail.com>
 <CA+yXCZArqonn6wq2kbu4kwBnFZ9xQuLfyb1i__qkD6VSi2tD5A@mail.gmail.com>
 <5cabdbd3-2317-59d0-b12d-f6611efd1103@ubuntu.com>
Message-ID: <4068032b-aaa4-5eae-4955-f3d0cfad2e71@ubuntu.com>
Date: Fri, 4 Dec 2020 15:41:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <5cabdbd3-2317-59d0-b12d-f6611efd1103@ubuntu.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,
 SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Dec 2020 14:41:14 -0000

On 12/4/20 2:38 PM, Matthias Klose wrote:
> On 12/4/20 9:07 AM, Kito Cheng via Gcc-patches wrote:
>> Committed, thanks :)
>>
>> On Thu, Dec 3, 2020 at 8:51 AM Jim Wilson <jimw@sifive.com> wrote:
>>>
>>> On Tue, Dec 1, 2020 at 12:13 AM Kito Cheng <kito.cheng@sifive.com> wrote:
>>>>
>>>>  - We would like to canonicalize the arch string for --with-arch for
>>>>    easier handling multilib, so split canonicalization part to a stand
>>>>    along script to shared the logic.
>>>>
>>>> gcc/ChangeLog:
>>>>
>>>>         * config/riscv/multilib-generator (arch_canonicalize): Move
>>>>         code to arch-canonicalize, and call that script to canonicalize arch
>>>>         string.
>>>>         (canonical_order): Move code to arch-canonicalize.
>>>>         (LONG_EXT_PREFIXES): Ditto.
>>>>         (IMPLIED_EXT): Ditto.
>>>>         * config/riscv/arch-canonicalize: New.
>>>>         * config.gcc (riscv*-*-*): Canonicalize --with-arch.
>>>
>>>
>>> Looks OK to me.
> 
> that breaks the bootstrap if python is not available. The python command might
> not be available, so please check for python3, python, or python2.

same for config/riscv/arch-canonicalize