From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8426 invoked by alias); 22 Dec 2009 18:50:30 -0000 Received: (qmail 8418 invoked by uid 22791); 22 Dec 2009 18:50:30 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f203.google.com (HELO mail-pz0-f203.google.com) (209.85.222.203) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Dec 2009 18:50:23 +0000 Received: by pzk41 with SMTP id 41so372232pzk.0 for ; Tue, 22 Dec 2009 10:50:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.25.19 with SMTP id c19mr6085731wfj.87.1261507821583; Tue, 22 Dec 2009 10:50:21 -0800 (PST) In-Reply-To: <6dc9ffc80912221045s10512e65w75dad381d691e5e1@mail.gmail.com> References: <407016140912221000o1c69d392x68607f8f529eaa7d@mail.gmail.com> <6dc9ffc80912221013s4e56445bwc45a2c9768fe15c3@mail.gmail.com> <407016140912221016t98b1cb7ve13c596f074525ff@mail.gmail.com> <6dc9ffc80912221024l3ab28f66m1c773f74cd23db89@mail.gmail.com> <407016140912221042i4caa2536s3a8bf612a24d8544@mail.gmail.com> <6dc9ffc80912221045s10512e65w75dad381d691e5e1@mail.gmail.com> Date: Tue, 22 Dec 2009 20:37:00 -0000 Message-ID: <407016140912221050o4d9a171v53906e4714bdc2f1@mail.gmail.com> Subject: Re: plugin event for C/C++ declarations From: Brian Hackett To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-12/txt/msg01043.txt.bz2 OK, here is an updated ChangeLog: 2009-12-22 Brian Hackett gcc/ChangeLog: * plugin.def: Add event for finish_decl. * plugin.c (register_callback, invoke_plugin_callbacks): Same. * c-decl.c (finish_decl): Invoke callbacks on above event. * doc/plugins.texi: Document above event. gcc/cp/ChangeLog: * decl.c (cp_finish_decl): Invoke callbacks on finish_decl event. gcc/testsuite/ChangeLog: * g++.dg/plugin/decl_plugin.c: New test plugin. * g++.dg/plugin/decl-plugin-test.C: Testcase for above plugin. * g++.dg/plugin/plugin.exp On Tue, Dec 22, 2009 at 10:45 AM, H.J. Lu wrote: > On Tue, Dec 22, 2009 at 10:42 AM, Brian Hackett = wrote: >> Where should texi ChangeLog changes go? =A0There's no changelog in >> gcc/doc and no .texi updates in gcc/ChangeLog. > > They should be listed in gcc/ChanngeLog: > > [hjl@gnu-6 gcc]$ grep doc/ gcc/ChangeLog | head -10 > =A0 =A0 =A0 =A0* doc/plugins.texi: Rename pre-genericize event. > =A0 =A0 =A0 =A0* doc/invoke.texi: Fix typo. > =A0 =A0 =A0 =A0* doc/tm.texi (ARG_POINTER_CFA_OFFSET): Document new defau= lt. > =A0 =A0 =A0 =A0* doc/rtl.texi (Vector Operations): Clarify vec_select res= ult mode. > =A0 =A0 =A0 =A0* doc/invoke.texi, doc/options.texi, doc/plugins.texi, > =A0 =A0 =A0 =A0doc/tm.texi: Fix typos. > =A0 =A0 =A0 =A0* doc/extend.texi (Function Attributes, Extended Asm): > =A0 =A0 =A0 =A0* doc/md.texi (Standard Names): Likewise. > =A0 =A0 =A0 =A0* doc/plugins.texi (Plugins): Likewise. > =A0 =A0 =A0 =A0* doc/c-tree.texi (Expression trees): Use @itemx for all b= ut > [hjl@gnu-6 gcc]$ > >> Brian >> >> On Tue, Dec 22, 2009 at 10:24 AM, H.J. Lu wrote: >>> On Tue, Dec 22, 2009 at 10:16 AM, Brian Hackett wrote: >>>> Hi, I added comments/documentation in plugin.def and doc/plugins.texi >>>> consistent with other plugins. =A0Is there another place documentation >>>> should go? >>> >>> doc/plugins.texi isn't mentioned in ChangeLog. >>> >>> >>> H.J. >>> --- >>>> Brian >>>> >>>> On Tue, Dec 22, 2009 at 10:13 AM, H.J. Lu wrote: >>>>> On Tue, Dec 22, 2009 at 10:00 AM, Brian Hackett wrote: >>>>>> Hi, this patch adds a new plugin event FINISH_DECL, which is invoked >>>>>> at every finish_decl in the C and C++ frontends. =A0Previously there= did >>>>>> not seem to be a way for a plugin to see the definition for a global >>>>>> that is never used in the input file, or the initializer for a global >>>>>> which is declared before a function but defined after. =A0This event >>>>>> isn't restricted to just globals though, but also locals, fields, and >>>>>> parameters (C frontend only). >>>>>> >>>>>> Brian >>>>>> >>>>>> >>>>>> >>>>>> 2009-12-22 =A0Brian Hackett =A0 >>>>>> >>>>>> gcc/ChangeLog: >>>>>> >>>>>> =A0 =A0 =A0 =A0* plugin.def: Add event for finish_decl. >>>>>> =A0 =A0 =A0 =A0* plugin.c (register_callback, invoke_plugin_callback= s): Same. >>>>>> =A0 =A0 =A0 =A0* c-decl.c (finish_decl): Invoke callbacks on above e= vent. >>>>>> >>>>> >>>>> Shouldn't it be documented? >>>>> >>>>> >>> >> > > > > -- > H.J. >