From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 55F69385840D for ; Mon, 24 Apr 2023 20:48:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55F69385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.99,223,1677571200"; d="scan'208";a="3796061" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 24 Apr 2023 12:48:31 -0800 IronPort-SDR: RSCt7G4/o2pzJKpV0jOGmQI9zL6wCKIb0y8j0k/Xuexy+RCvkLhXG8Ct9fNu9OHcR/aehoLBOu /rkRPQF2VrdbW6Gw/uAwYkFG7D5ElZPzOKyW/SRRTfLoCx+vWMZqYFWZcf/2ejydMVaqDS713N lpBqHotk1trTwWQQLuoQRe2a+rna/1g1FVz65Iv3z0a/cVZnv49o9KQjquEUi1WmZUDXMGlQTo C5pYPRPEFoT04AZuixAjyQ8N1vqvXYU+uVtLRbIisAQcsqfrSS8CAVBSospXHMLc9p/1jypvR9 K7Y= Date: Mon, 24 Apr 2023 20:48:26 +0000 From: Joseph Myers To: Jakub Jelinek CC: Marek Polacek , Subject: Re: [PATCH] c: Fix up error-recovery on non-empty VLA initializers [PR109409] In-Reply-To: Message-ID: <4080d3a8-a38c-ddf-311e-5dfdab76ca9a@codesourcery.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3107.1 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 14 Apr 2023, Jakub Jelinek via Gcc-patches wrote: > Hi! > > On the following testcase we ICE, because after we emit the > variable-sized object may not be initialized except with an empty initializer > error we don't really reset the initializer to error_mark_node and then at > -Wformat checking time we ICE on seeing STRING_CST initializer for a VLA. > > The following patch just arranges for error_mark_node to be returned after > the error diagnostics. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK. -- Joseph S. Myers joseph@codesourcery.com