From: Joseph Myers <joseph@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <rguenther@suse.de>, <gcc-patches@gcc.gnu.org>
Subject: Re: Patch ping Re: [PATCH 0/12] GCC _BitInt support [PR102989]
Date: Mon, 21 Aug 2023 17:32:04 +0000 [thread overview]
Message-ID: <409a2da3-1c2d-e62-6f7-8a3ec74871c7@codesourcery.com> (raw)
In-Reply-To: <ZOOBkkswPQz+qk+G@tucnak>
On Mon, 21 Aug 2023, Jakub Jelinek via Gcc-patches wrote:
> Joseph, could I ask now at least for an overall design review of the
> C patches (8-10,13) whether its interfaces with middle-end are ok,
> so that Richi can review the middle-end parts?
I am fine with the interface to the middle-end parts.
I think the libgcc functions (i.e. those exported by libgcc, to which
references are generated by the compiler) need documenting in libgcc.texi.
Internal functions or macros in the libgcc patch need appropriate comments
specifying their semantics; especially FP_TO_BITINT and FP_FROM_BITINT
which have a lot of arguments and no comments saying what the semantics of
the macros and their arguments are supposed to me.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-08-21 17:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 18:14 Jakub Jelinek
2023-08-09 21:17 ` Joseph Myers
2023-08-10 6:55 ` Richard Biener
2023-08-10 7:12 ` Jakub Jelinek
2023-08-10 7:26 ` Andrew Pinski
2023-08-10 10:10 ` [PATCH 13/12] C _BitInt incremental fixes [PR102989] Jakub Jelinek
2023-08-10 15:22 ` [PATCH 13/12 v2] " Jakub Jelinek
2023-09-05 22:26 ` Joseph Myers
2023-08-21 15:24 ` Patch ping Re: [PATCH 0/12] GCC _BitInt support [PR102989] Jakub Jelinek
2023-08-21 17:32 ` Joseph Myers [this message]
2023-08-22 11:28 ` [PATCH 14/12] libgcc _BitInt helper documentation [PR102989] Jakub Jelinek
2023-09-01 21:32 ` Joseph Myers
2023-09-02 11:41 ` Jakub Jelinek
2023-08-22 22:48 ` Patch ping Re: [PATCH 0/12] GCC _BitInt support [PR102989] Andrew Pinski
2023-08-28 9:04 ` Patch ping^2 " Jakub Jelinek
2023-09-18 11:39 ` Matthew Malcomson
2023-09-18 21:31 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409a2da3-1c2d-e62-6f7-8a3ec74871c7@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).