From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 180663858CD1 for ; Mon, 21 Aug 2023 17:32:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 180663858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.01,190,1684828800"; d="scan'208";a="14984889" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 21 Aug 2023 09:32:09 -0800 IronPort-SDR: 4aSnj4+LJ4D+a/zZFWS83OAZU4esa4KMxQOoA2PAS5MC27xt5fWzsssF1WE+FMTob6YCUA63Jo NXDyp6lWoUsxEObLAlXrdOPrXdlmm1ctX71JwDXm1fXEgkgNkdZdLpGinuA2y81hERdvcGPyru 3E7CeFRbY+BSZvui8rjWttrIsF0xMQUQGQewQuQ53hYY6xGH84MY7Tb14s/Y/wwqyipxqUglXX EL9DxgoKSBvrZlggHfZ9agBN2/wTUGyfIrQpWuTHFyL1UghyKruWty/X/V3Uy1a7UtAYNh4yly ptI= Date: Mon, 21 Aug 2023 17:32:04 +0000 From: Joseph Myers To: Jakub Jelinek CC: Richard Biener , Subject: Re: Patch ping Re: [PATCH 0/12] GCC _BitInt support [PR102989] In-Reply-To: Message-ID: <409a2da3-1c2d-e62-6f7-8a3ec74871c7@codesourcery.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3104.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 21 Aug 2023, Jakub Jelinek via Gcc-patches wrote: > Joseph, could I ask now at least for an overall design review of the > C patches (8-10,13) whether its interfaces with middle-end are ok, > so that Richi can review the middle-end parts? I am fine with the interface to the middle-end parts. I think the libgcc functions (i.e. those exported by libgcc, to which references are generated by the compiler) need documenting in libgcc.texi. Internal functions or macros in the libgcc patch need appropriate comments specifying their semantics; especially FP_TO_BITINT and FP_FROM_BITINT which have a lot of arguments and no comments saying what the semantics of the macros and their arguments are supposed to me. -- Joseph S. Myers joseph@codesourcery.com