Unreviewed C++ patch

Unreviewed C++ patch

[Giovanni Bajo]

Hello,

I posted this patch in April and forgot about it myself after it went
unreviewed:

[PR7841] Fix invalid name of constructor
http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01197.html

Thank you,
Giovanni Bajo

Re: Unreviewed C++ patch

[Gabriel Dos Reis]

"Giovanni Bajo" <giovannibajo@libero.it> writes:

| Hello,
| 
| I posted this patch in April and forgot about it myself after it went
| unreviewed:
| 
| [PR7841] Fix invalid name of constructor
| http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01197.html

Since you detect the problem and know about what is going on, the
error message 

  error: invalid use of argument list for a constructor in a qualified name

is a bit unclear.  What about

  error: invalid use of constructor 'X<dim>::X' as a template

?

We should also reject the follwoing

    X<dim>::X<dim>  x;

and

   struct A { };

   A::A a;

-- Gaby

Re: Unreviewed C++ patch

[Mark Mitchell]

Giovanni Bajo wrote:

>Hello,
>
>I posted this patch in April and forgot about it myself after it went
>unreviewed:
>
>[PR7841] Fix invalid name of constructor
>http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01197.html
>
OK.

-- 
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com

Re: Unreviewed C++ patch

[Giovanni Bajo]

Gabriel Dos Reis wrote:

>> [PR7841] Fix invalid name of constructor
>> http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01197.html
>
> Since you detect the problem and know about what is going on, the
> error message
>
>   error: invalid use of argument list for a constructor in a
> qualified name
>
> is a bit unclear.  What about
>
>   error: invalid use of constructor 'X<dim>::X' as a template
>
> ?

Sure, but I kept the inform() so I don't name the expression in the diagnostic.
I'm committing this (given also Mark's approval):

      error ("invalid use of constructor as a template");
      inform ("use `%T::%D' instead of `%T::%T' to name the "
       "constructor in a qualified name", class_type,
       DECL_NAME (TYPE_TI_TEMPLATE (class_type)),
       class_type, class_type);

> We should also reject the follwoing
>
>     X<dim>::X<dim>  x;
>
> and
>
>    struct A { };
>    A::A a;

This is different though. I filed PR 15865 to track this.

Giovanni Bajo

Re: Unreviewed C++ patch

[Gabriel Dos Reis]

You Wrote Giovanni Bajo
> Gabriel Dos Reis wrote:
>
>>> [PR7841] Fix invalid name of constructor
>>> http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01197.html
>>
>> Since you detect the problem and know about what is going on, the
>> error message
>>
>>   error: invalid use of argument list for a constructor in a
>> qualified name
>>
>> is a bit unclear.  What about
>>
>>   error: invalid use of constructor 'X<dim>::X' as a template
>>
>> ?
>
> Sure, but I kept the inform() so I don't name the expression in the
> diagnostic.
> I'm committing this (given also Mark's approval):
>
>       error ("invalid use of constructor as a template");
>       inform ("use `%T::%D' instead of `%T::%T' to name the "
>        "constructor in a qualified name", class_type,
>        DECL_NAME (TYPE_TI_TEMPLATE (class_type)),
>        class_type, class_type);

That is good.

>
>> We should also reject the follwoing
>>
>>     X<dim>::X<dim>  x;
>>
>> and
>>
>>    struct A { };
>>    A::A a;
>
> This is different though. I filed PR 15865 to track this.

OK. I think I filled (some time ago) a PR about GCC not handling
injected class-name correctly.  They are same.

Thanks,

Unreviewed C++ patch

[Giovanni Bajo]

Hello,

this patch is still unreviewed:

TC1 testsuite (part 2/N) 
http://gcc.gnu.org/ml/gcc-patches/2004-02/msg00000.html

Thanks
Giovanni Bajo

Unreviewed C++ patch

[Giovanni Bajo]

Hello,

this patch is still unreviewed:

TC1 testsuite (part 2/N) 
http://gcc.gnu.org/ml/gcc-patches/2004-02/msg00000.html

Thanks
Giovanni Bajo

Unreviewed C++ patch

[Giovanni Bajo]

Hello,

[PR13813] Incomplete type for member variables of class templates 
http://gcc.gnu.org/ml/gcc-patches/2004-01/msg02443.html

Thanks in advance
Giovanni Bajo