From: Mark Mitchell <mark@codesourcery.com>
To: Daniel Berlin <dberlin@dberlin.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH]: Add documentation for functions in tree-flow-inline.h
Date: Tue, 15 Jun 2004 19:26:00 -0000 [thread overview]
Message-ID: <40CF3A1D.8030209@codesourcery.com> (raw)
In-Reply-To: <2329F56A-BEF5-11D8-AF3E-000A95DA505C@dberlin.org>
Daniel Berlin wrote:
>
> On Jun 15, 2004, at 11:06 AM, Mark Mitchell wrote:
>
>> Daniel --
>>
>> These functions are all missing comments. There should be a comment
>> for every parameter and an explanation of the value returned.
>
>
> Okey.
>
> As penance, I also added comments for all the other functions in that
> file, which were all missing this documentation.
>
> I've attached the patch for review
Yay! Looks good.
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
prev parent reply other threads:[~2004-06-15 18:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 18:27 [PATCH]: Add annotations for expression and constants Daniel Berlin
2004-06-10 14:28 ` Diego Novillo
2004-06-10 14:28 ` Daniel Berlin
2004-06-10 14:55 ` Diego Novillo
2004-06-10 15:38 ` Daniel Berlin
2004-06-15 16:14 ` Mark Mitchell
2004-06-15 19:09 ` [PATCH]: Add documentation for functions in tree-flow-inline.h Daniel Berlin
2004-06-15 19:26 ` Mark Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CF3A1D.8030209@codesourcery.com \
--to=mark@codesourcery.com \
--cc=dberlin@dberlin.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).