From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30720 invoked by alias); 15 Jun 2004 18:04:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30693 invoked from network); 15 Jun 2004 18:04:12 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.5) by sourceware.org with SMTP; 15 Jun 2004 18:04:12 -0000 Received: (qmail 6618 invoked from network); 15 Jun 2004 18:04:09 -0000 Received: from 227.148-60-66-fuji-dsl.static.surewest.net (HELO codesourcery.com) (mitchell@66.60.148.227) by mail.codesourcery.com with SMTP; 15 Jun 2004 18:04:09 -0000 Message-ID: <40CF3A1D.8030209@codesourcery.com> Date: Tue, 15 Jun 2004 19:26:00 -0000 From: Mark Mitchell Organization: CodeSourcery, LLC User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113 MIME-Version: 1.0 To: Daniel Berlin CC: GCC Patches Subject: Re: [PATCH]: Add documentation for functions in tree-flow-inline.h References: <1C733CAA-B7D9-11D8-909E-000A95DA505C@dberlin.org> <40CF107D.9060408@codesourcery.com> <2329F56A-BEF5-11D8-AF3E-000A95DA505C@dberlin.org> In-Reply-To: <2329F56A-BEF5-11D8-AF3E-000A95DA505C@dberlin.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-06/txt/msg01216.txt.bz2 Daniel Berlin wrote: > > On Jun 15, 2004, at 11:06 AM, Mark Mitchell wrote: > >> Daniel -- >> >> These functions are all missing comments. There should be a comment >> for every parameter and an explanation of the value returned. > > > Okey. > > As penance, I also added comments for all the other functions in that > file, which were all missing this documentation. > > I've attached the patch for review Yay! Looks good. -- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com