From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 879AD385802E for ; Wed, 5 May 2021 07:23:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 879AD385802E Received: by mail-wm1-x336.google.com with SMTP id o127so763395wmo.4 for ; Wed, 05 May 2021 00:23:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uo4u+HlseK2loLvUGCDka9ftrlG6yYe+vbm204LlkqE=; b=KIsL7OyujeUBOt1dUsMqcUck8zWqrLrfxWPjt2n8zZ8oNO7FWUhbfkMzkLeAREMV/K u5PBYDsQEj+MtlRt6NToBF51/Go1O0FKz09eVoezhzm615jNZrQZq4YszDrvlmE5iYPq ReyhP0k/f4NICrU0IG3/wwKb/j4IyFxuzTBvwWLtaHUljcoxWrtUbzznOwqFwpVjufji 7Gt0HHeomB5saN3x30RW//MatUtgBWML48VjD0De/YH9Vh1jPyeNjNdtBdfob4ZFqgvA sUtW1Tubdg3WTaKd8TNRW35pGHVLAh7zMdrIAsYk5io6rPWaBCEp2OnjKIGfu4WV75XX RdoQ== X-Gm-Message-State: AOAM530AKJpXZAR8n+Heu1UUrgIKNvXszS1aDbo2X7IRct66IdDdVzc1 RSbslM9UsigZzsw/iYe3Ywo= X-Google-Smtp-Source: ABdhPJwnmtawHQ/N2j54jCsAJFt+IfhOQ2GVwBA83xLMHrmSV5xiVrptDZerzS/WAVdATXJSnzlwMQ== X-Received: by 2002:a1c:7c03:: with SMTP id x3mr1764884wmc.122.1620199400651; Wed, 05 May 2021 00:23:20 -0700 (PDT) Received: from [192.168.1.212] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id i3sm20506431wrb.46.2021.05.05.00.23.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 May 2021 00:23:20 -0700 (PDT) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure From: Iain Sandoe In-Reply-To: <20210505072052.GA14297@bubble.grove.modra.org> Date: Wed, 5 May 2021 08:23:19 +0100 Cc: Nick Clifton , GCC Patches , "H.J. Lu" Content-Transfer-Encoding: 8bit Message-Id: <40EABDAE-EC80-495C-8300-738C3348D4B9@googlemail.com> References: <8c1b0ed9-e6f3-9c22-45c5-c2680a2a4830@polymtl.ca> <3e562764-ce93-d4a2-fbba-dc622c9b5bb7@redhat.com> <3c76d8a1-d029-237d-054c-0ff65eb063cb@polymtl.ca> <20210505001825.GN22624@bubble.grove.modra.org> <20210505072052.GA14297@bubble.grove.modra.org> To: Alan Modra X-Mailer: Apple Mail (2.3273) X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 07:23:23 -0000 Alan Modra wrote: > On Wed, May 05, 2021 at 08:05:29AM +0100, Iain Sandoe wrote: >> Alan Modra via Gcc-patches wrote: >> >>> On 2021-05-04 8:42 a.m., Nick Clifton wrote: >>>> Hi Guys, >>>> >>>> On 4/30/21 7:36 PM, Simon Marchi wrote: >>>>> I think this fix is obvious enough, I encourage you to push it, >>>> >>>> OK - I have pushed the patch to the mainline branches of both >>>> the gcc and binutils-gdb repositories. >>> >>> Thanks Nick! Incidentally, I checked the AC_PROG_CC_C99 change on >>> both binutils and gcc mainline using gcc-4.9. >>> >>> To build gcc on x86_64 I found the following patch necessary to avoid >>> lots of >>> error: uninitialized const member ‘stringop_algs::stringop_strategy::max’ >>> error: uninitialized const member ‘stringop_algs::stringop_strategy::alg’ >>> when compiling config/i386/i386-options.c. These can't be cured by >>> configuring with --disable-stage1-checking. >>> >>> diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h >>> index 97d6f3863cb..cc3b1b6d666 100644 >>> --- a/gcc/config/i386/i386.h >>> +++ b/gcc/config/i386/i386.h >>> @@ -73,8 +73,8 @@ struct stringop_algs >>> { >>> const enum stringop_alg unknown_size; >>> const struct stringop_strategy { >>> - const int max; >>> - const enum stringop_alg alg; >>> + int max; >>> + enum stringop_alg alg; >>> int noalign; >>> } size [MAX_STRINGOP_ALGS]; >>> }; >> >> does this relate to / fix PR 100246 (which seems to fire for some GCC >> versions as well >> as older clang)? > > Yes, looks like the same issue. I started making a similar fix to the > one you attached to the PR, then laziness kicked in after noticing the > errors were only given on the const elements. OK, so this has been applied to master already IIUC - I will queue up a run to check master is OK with the clang versions that fail. It will be needed on GCC11.2 as well. thanks Iain