public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bob Wilson <bwilson@tensilica.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: gimple va_arg for xtensa
Date: Wed, 14 Jul 2004 07:05:00 -0000	[thread overview]
Message-ID: <40F46D4D.2020707@tensilica.com> (raw)
In-Reply-To: <20040709104104.GB8129@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

I committed this patch on the mainline to fix a small problem in the new vararg 
code for Xtensa.  Thanks to Richard for doing the hard part!

--Bob

2004-07-13  Bob Wilson  <bob.wilson@acm.org>

	* config/xtensa/xtensa.c (xtensa_gimplify_va_arg_expr): Swap
	arguments for COND_EXPR in big-endian adjustment code.


[-- Attachment #2: gcc-var-arg.diff --]
[-- Type: text/plain, Size: 635 bytes --]

Index: xtensa.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/xtensa/xtensa.c,v
retrieving revision 1.61
diff -u -p -r1.61 xtensa.c
--- xtensa.c	9 Jul 2004 10:13:16 -0000	1.61
+++ xtensa.c	13 Jul 2004 22:30:37 -0000
@@ -2621,7 +2621,7 @@ xtensa_gimplify_va_arg_expr (tree valist
     {
       t = size_int (PARM_BOUNDARY / BITS_PER_UNIT);
       t = fold (build (GE_EXPR, boolean_type_node, type_size, t));
-      t = fold (build (COND_EXPR, sizetype, t, type_size, va_size));
+      t = fold (build (COND_EXPR, sizetype, t, va_size, type_size));
       size = t;
     }
   else

      reply	other threads:[~2004-07-13 23:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-09 10:49 Richard Henderson
2004-07-09 12:08 ` Richard Henderson
2004-07-14  7:05   ` Bob Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40F46D4D.2020707@tensilica.com \
    --to=bwilson@tensilica.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).