From: Tobias Burnus <tobias@codesourcery.com>
To: Andrew Stubbs <ams@codesourcery.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v3 1/3] libgomp, nvptx: low-latency memory allocator
Date: Tue, 5 Dec 2023 18:13:03 +0100 [thread overview]
Message-ID: <40c29c92-e100-4e19-bb7b-2bca5a6a25db@codesourcery.com> (raw)
In-Reply-To: <09994c27-bcf6-41b5-86db-73a74bbad01b@codesourcery.com>
On 05.12.23 16:39, Andrew Stubbs wrote:
>> Hence, mentioning in this section in addition that
>> omp_low_lat_mem_space is honored on devices
>> seems to be the better location.
>
> How about this?
LGTM – Thanks!
Tobias
> --- a/libgomp/libgomp.texi
> +++ b/libgomp/libgomp.texi
> @@ -3012,9 +3012,9 @@ value.
> @item omp_const_mem_alloc @tab omp_const_mem_space
> @item omp_high_bw_mem_alloc @tab omp_high_bw_mem_space
> @item omp_low_lat_mem_alloc @tab omp_low_lat_mem_space
> -@item omp_cgroup_mem_alloc @tab --
> -@item omp_pteam_mem_alloc @tab --
> -@item omp_thread_mem_alloc @tab --
> +@item omp_cgroup_mem_alloc @tab omp_low_lat_mem_space
> (implementation defined)
> +@item omp_pteam_mem_alloc @tab omp_low_lat_mem_space
> (implementation defined)
> +@item omp_thread_mem_alloc @tab omp_low_lat_mem_space
> (implementation defined)
> @end multitable
>
> The predefined allocators use the default values for the traits,
> @@ -3060,7 +3060,7 @@
> OMP_ALLOCATOR=omp_low_lat_mem_space:pinned=true,partition=nearest
>
> @item @emph{See also}:
> @ref{Memory allocation}, @ref{omp_get_default_allocator},
> -@ref{omp_set_default_allocator}
> +@ref{omp_set_default_allocator}, @ref{Offload-Target Specific}
>
> @item @emph{Reference}:
> @uref{https://www.openmp.org/, OpenMP specification v5.0}, Section 6.21
> @@ -5710,7 +5710,8 @@ For the memory spaces, the following applies:
> @itemize
> @item @code{omp_default_mem_space} is supported
> @item @code{omp_const_mem_space} maps to @code{omp_default_mem_space}
> -@item @code{omp_low_lat_mem_space} maps to @code{omp_default_mem_space}
> +@item @code{omp_low_lat_mem_space} is only available on supported
> devices,
> + and maps to @code{omp_default_mem_space} otherwise.
> @item @code{omp_large_cap_mem_space} maps to
> @code{omp_default_mem_space},
> unless the memkind library is available
> @item @code{omp_high_bw_mem_space} maps to @code{omp_default_mem_space},
> @@ -5766,6 +5767,9 @@ Additional notes regarding the traits:
> @item The @code{sync_hint} trait has no effect.
> @end itemize
>
> +See also:
> +@ref{Offload-Target Specifics}
> +
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2023-12-05 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 0:32 [PATCH v3 0/3] libgomp: OpenMP low-latency omp_alloc Andrew Stubbs
2023-12-03 0:32 ` [PATCH v3 1/3] libgomp, nvptx: low-latency memory allocator Andrew Stubbs
2023-12-04 16:04 ` Tobias Burnus
2023-12-05 15:39 ` Andrew Stubbs
2023-12-05 17:13 ` Tobias Burnus [this message]
2023-12-05 11:25 ` Tobias Burnus
2023-12-03 0:32 ` [PATCH v3 2/3] openmp, nvptx: low-lat memory access traits Andrew Stubbs
2023-12-03 0:32 ` [PATCH v3 3/3] amdgcn, libgomp: low-latency allocator Andrew Stubbs
2023-12-04 15:34 ` [PATCH v3 0/3] libgomp: OpenMP low-latency omp_alloc Tobias Burnus
2023-12-04 15:53 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40c29c92-e100-4e19-bb7b-2bca5a6a25db@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).