From: Martin Sebor <msebor@gmail.com>
To: Tom Honermann <tom@honermann.net>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [REVISED PATCH 1/9]: C++ P0482R5 char8_t: Documentation updates
Date: Sat, 05 Jan 2019 00:40:00 -0000 [thread overview]
Message-ID: <40c86900-a6cd-9c19-3ad9-2a9b3bd8977e@gmail.com> (raw)
In-Reply-To: <396315c1-7a7c-d981-b9c6-a5e76bb011a0@honermann.net>
On 12/23/18 7:27 PM, Tom Honermann wrote:
> Attached is a revised patch that addresses feedback provided by Jason
> and Sandra. Changes from the prior patch include:
> - Updates to the -fchar8_t option documentation as requested by Jason.
> - Corrections for indentation, spacing, hyphenation, and wrapping as
> Â requested by Sandra.
>
Just a minor nit that backticks in code examples should be avoided
(per the TexInfo manual, they can cause trouble when copying code
from PDF readers):
+@smallexample
+char ca[] = u8"xx"; // error: char-array initialized from wide
+ // string
+const char *cp = u8"xx";// error: invalid conversion from
+ // `const char8_t*' to `const char*'
Martin
next prev parent reply other threads:[~2019-01-05 0:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 19:39 [PATCH " Tom Honermann
2018-12-03 19:59 ` Jason Merrill
2018-12-05 7:10 ` Tom Honermann
2018-12-05 15:05 ` Jason Merrill
2018-12-11 23:35 ` Sandra Loosemore
2018-12-24 2:28 ` Tom Honermann
2018-12-24 2:27 ` [REVISED PATCH " Tom Honermann
2019-01-05 0:40 ` Martin Sebor [this message]
2019-01-15 4:30 ` Tom Honermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40c86900-a6cd-9c19-3ad9-2a9b3bd8977e@gmail.com \
--to=msebor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tom@honermann.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).