From: Eric Botcazou <botcazou@adacore.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Mikael Pettersson <mikpelinux@gmail.com>,
Arnaud Charlet <charlet@adacore.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2] fix Ada bootstrap on Cygwin64 (PR bootstrap/94918)
Date: Mon, 08 Mar 2021 12:07:47 +0100 [thread overview]
Message-ID: <4113159.e1GE0xNht7@fomalhaut> (raw)
In-Reply-To: <CAFiYyc0xcZjra9-wky=fGYbwdR3_RpXLUW_z7Yy0MN81SP7FyA@mail.gmail.com>
> I wonder why we include <windows.h> from this file at all,
> and why it is not included from {t,}system.h instead which
> is where system header specific fixups should be made
> (and this one could be avoided because system headers
> are included _before_ poisoning anything).
<windows.h> is the Mother of All Things on the platform so you don't want to
include it liberally (although it can be tamed e.g. with WIN32_LEAN_AND_MEAN).
Therefore including it from tsystem.h might be worse than the actual disease.
Mikael, can you work around the problem by adding
#ifdef __CYGWIN__
#include "mingw32.h"
#endif
at the appropriate spot in raise-gcc.c instead?
--
Eric Botcazou
next prev parent reply other threads:[~2021-03-08 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 10:44 Mikael Pettersson
2021-01-10 10:57 ` Arnaud Charlet
2021-01-10 13:04 ` Mikael Pettersson
2021-03-07 17:16 ` Mikael Pettersson
2021-03-07 18:20 ` Arnaud Charlet
2021-03-08 10:21 ` Richard Biener
2021-03-08 11:07 ` Eric Botcazou [this message]
2021-03-08 21:43 ` Mikael Pettersson
2021-03-08 22:21 ` Eric Botcazou
2021-03-09 16:00 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4113159.e1GE0xNht7@fomalhaut \
--to=botcazou@adacore.com \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikpelinux@gmail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).