From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id C803F3858D1E for ; Tue, 7 Nov 2023 21:59:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C803F3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C803F3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699394378; cv=none; b=mG+wRQTGd2AKTkdIg1ZIlB3OWJTM/4hRhYOp6GZFTBKrRfhkpjSTg+XBkXjgZ0ynXwW1FDMd7h/7td3SdOydpN38gj+FF865t262Z3o1o47pOc7k8vKJEMCtylbhOekhe5hdu17Ud1qRNCWrjljPG677uKYb9AXXn9INqkz8jPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699394378; c=relaxed/simple; bh=PoGHcOS3hvcC69qXDhsRJMEiCMqnXXjjVZ9rAYQ90DM=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=aGRj095belLDqTBBqfJqeuiOv+HVgHO9ZyQaHiJyOHhsjE8WvZkDy7FdVXHumXiyBlDJPToIIKg11B156VuVPrNYl++hlP2+XkUufK+6aVNUfOSrp27CFiZnt3xa49InXPP7MU0eBe0vmF4ExSb7rECpytdjyTP+tQ+8xUrXhTI= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: Ano2DNM9QkKjbiRPb5pN+Q== X-CSE-MsgGUID: Jy+FwPEISua9s5oAQ8zhKw== X-IronPort-AV: E=Sophos;i="6.03,284,1694764800"; d="scan'208";a="25085873" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 07 Nov 2023 13:59:34 -0800 IronPort-SDR: e6O2ZGjCe2Mva6U9bExRwlKlxPBqlt8FIpaiejZ9LfVZF1kTR9z+UDHP0bmjYkWRxpsl8ti+jW tEKGqHQ5zrnls9CgpGnOfyzZao+g7Te1605Fo/u5L757qKCLF6vyDxMkPHmOYPOyFU2PRWwhB1 rFqMjSxUKjKJhPB08CZvlS9272e6y+DuxcwNVnqaFFxzz6zklYZ4Syp9BO4XB8MfQFr1SD9hop y2NGJdAz07xjGACMUFl62EzVT6dmpC74mPgrV+wLoDOH8JjCx8fu/xB+g6UZ7Dy1AcmwbRHUSD LLg= Message-ID: <4116c1ad-818c-4d3c-9c2a-9ae1dcd2328e@codesourcery.com> Date: Tue, 7 Nov 2023 21:59:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] openmp: Add support for the 'indirect' clause in C/C++ To: Jakub Jelinek , Joseph Myers CC: Tobias Burnus , gcc-patches References: <37f412ee-58e7-4bde-a763-591268e8f8f4@codesourcery.com> <67d99da-e69-56b4-1785-38b964143ec9@codesourcery.com> Content-Language: en-GB From: Kwok Cheung Yeung In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Yes, I believe that is the right fix. The version in libgomp/config/accel/ should then override the version in libgomp/ for accelerator targets. I'll do a quick check that this works as expected and push it ASAP. Sorry for breaking the build for so many targets! Kwok On 07/11/2023 9:51 pm, Jakub Jelinek wrote: > On Tue, Nov 07, 2023 at 09:37:22PM +0000, Joseph Myers wrote: >> This looks like targets that libgomp/configure.tgt does *not* have any >> special handling for, and so never adds "linux" to config_path for. > > Indeed, I don't really see anything linux specific about the > libgomp/config/linux/target-indirect.c > so wonder if the right fix isn't > git mv libgomp/{config/linux/,}target-indirect.c > > Jakub >