Thanks for catching this. I still send V4 patch :) since I want to make kito && Jeff see the latest version. juzhe.zhong@rivai.ai From: Robin Dapp Date: 2023-06-06 19:58 To: juzhe.zhong; gcc-patches CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw; pan2.li Subject: Re: [PATCH] RISC-V: Add RVV vwmacc/vwmaccu/vwmaccsu combine lowering optmization > + rtx ops[] = {operands[0], operands[1], operands[2], operands[3]}; > + riscv_vector::emit_vlmax_ternary_insn (code_for_pred_widen_mul_plus (, mode), > + riscv_vector::RVV_WIDEN_TERNOP, ops); ops is still there ;) No need for another revision though. > +;; This helps to match ext + fma to enhance the combine optimizations. No need for the "to enhance the...".