* [Fwd: [gfortran] Fix PRs 17535, 17583, 17713]
@ 2004-10-10 16:52 Tobias Schlüter
2004-10-30 16:03 ` Paul Brook
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Schlüter @ 2004-10-10 16:52 UTC (permalink / raw)
To: GCC Fortran mailing list, patch
My original message didn't make it through, no matter what I tried, therefore
I only offer a very brief description of this patch, in order to not have this
rejected for the 15th time.
This patch also sets the module name on dummy arguments emitted into the
module file. This is a workaround, not a real fix, but it fixes the PRs
mentioned in the subject line. All these seem to be regressions that were
introduced when we fixed PR 16485.
Built and tested, I will commit the testcases from the PRs along with this. Ok?
- Tobi
2004-10-10 Tobias Schlueter <tobias.schlueter@physik.uni-muenchen.de>
PR fortran/17535
PR fortran/17583
PR fortran/17713
* module.c (write_symbol1): Set module_name for dummy arguments.
Index: module.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fortran/module.c,v
retrieving revision 1.19
diff -u -p -r1.19 module.c
--- module.c 10 Oct 2004 14:35:39 -0000 1.19
+++ module.c 10 Oct 2004 14:36:57 -0000
@@ -3269,6 +3269,11 @@ write_symbol1 (pointer_info * p)
if (p->type != P_SYMBOL || p->u.wsym.state != NEEDS_WRITE)
return 0;
+ /* FIXME: This shouldn't be necessary, but it works around
+ deficiencies in the module loader or/and symbol handling. */
+ if (p->u.wsym.sym->module[0] == '\0' && p->u.wsym.sym->attr.dummy)
+ strcpy (p->u.wsym.sym->module, module_name);
+
p->u.wsym.state = WRITTEN;
write_symbol (p->integer, p->u.wsym.sym);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Fwd: [gfortran] Fix PRs 17535, 17583, 17713]
2004-10-10 16:52 [Fwd: [gfortran] Fix PRs 17535, 17583, 17713] Tobias Schlüter
@ 2004-10-30 16:03 ` Paul Brook
0 siblings, 0 replies; 2+ messages in thread
From: Paul Brook @ 2004-10-30 16:03 UTC (permalink / raw)
To: fortran; +Cc: Tobias Schlüter, patch
> 2004-10-10 Tobias Schlueter <tobias.schlueter@physik.uni-muenchen.de>
>
> PR fortran/17535
> PR fortran/17583
> PR fortran/17713
> * module.c (write_symbol1): Set module_name for dummy arguments.
Ok.
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-30 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-10 16:52 [Fwd: [gfortran] Fix PRs 17535, 17583, 17713] Tobias Schlüter
2004-10-30 16:03 ` Paul Brook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).