[committed] aarch64: Adjust spellcheck tests for recent quotation-mark changes

[committed] aarch64: Adjust spellcheck tests for recent quotation-mark changes

[Richard Earnshaw]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Martin's recent change to the way we handle quotation marks and
punctuation in error messages caused some fallout in the testsuite.
This patch updates the tests for the new output.

....

Adjust tests for quotation-mark and punctuation changes.

gcc/testsuite:

	* gcc.target/aarch64/spellcheck_1.c: Adjust tests for new output.
	* gcc.target/aarch64/spellcheck_2.c: Likewise.
	* gcc.target/aarch64/spellcheck_3.c: Likewise.
	* gcc.target/aarch64/spellcheck_7.c: Likewise.
---
 gcc/testsuite/gcc.target/aarch64/spellcheck_1.c | 2 +-
 gcc/testsuite/gcc.target/aarch64/spellcheck_2.c | 2 +-
 gcc/testsuite/gcc.target/aarch64/spellcheck_3.c | 2 +-
 gcc/testsuite/gcc.target/aarch64/spellcheck_7.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-aarch64-Adjust-spellcheck-tests-for-recent-quotation.patch --]
[-- Type: text/x-patch; name="0001-aarch64-Adjust-spellcheck-tests-for-recent-quotation.patch", Size: 3050 bytes --]

diff --git a/gcc/testsuite/gcc.target/aarch64/spellcheck_1.c b/gcc/testsuite/gcc.target/aarch64/spellcheck_1.c
index a0795c1cc53..8654674fc67 100644
--- a/gcc/testsuite/gcc.target/aarch64/spellcheck_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/spellcheck_1.c
@@ -4,6 +4,6 @@ __attribute__((target ("arch=armv8-a-typo"))) void
 foo ()
 {
   /* { dg-message "valid arguments are: \[^\n\r]*(; did you mean 'armv*'?)?"  "" { target *-*-* } .-1 } */
-  /* { dg-error "invalid name \\(\"armv8-a-typo\"\\) in 'target\\(\"arch=\"\\)' pragma or attribute"  "" { target *-*-* } .-2 } */
+  /* { dg-error "invalid name \\('armv8-a-typo'\\) in 'target\\(\"arch=\"\\)' pragma or attribute"  "" { target *-*-* } .-2 } */
   /* { dg-error "pragma or attribute 'target\\(\"arch=armv8-a-typo\"\\)' is not valid"  "" { target *-*-* } .-3 } */
 }
diff --git a/gcc/testsuite/gcc.target/aarch64/spellcheck_2.c b/gcc/testsuite/gcc.target/aarch64/spellcheck_2.c
index 70096f89e0b..1cc2c0591dc 100644
--- a/gcc/testsuite/gcc.target/aarch64/spellcheck_2.c
+++ b/gcc/testsuite/gcc.target/aarch64/spellcheck_2.c
@@ -4,6 +4,6 @@ __attribute__((target ("cpu=cortex-a57-typo"))) void
 foo ()
 {
   /* { dg-message "valid arguments are: \[^\n\r]*; did you mean 'cortex-a57'?"  "" { target *-*-* } .-1 } */
-  /* { dg-error "invalid name \\(\"cortex-a57-typo\"\\) in 'target\\(\"cpu=\"\\)' pragma or attribute"  "" { target *-*-* } .-2 } */
+  /* { dg-error "invalid name \\('cortex-a57-typo'\\) in 'target\\(\"cpu=\"\\)' pragma or attribute"  "" { target *-*-* } .-2 } */
   /* { dg-error "pragma or attribute 'target\\(\"cpu=cortex-a57-typo\"\\)' is not valid"  "" { target *-*-* } .-3 } */
 }
diff --git a/gcc/testsuite/gcc.target/aarch64/spellcheck_3.c b/gcc/testsuite/gcc.target/aarch64/spellcheck_3.c
index 20dff2b6e45..9953872b679 100644
--- a/gcc/testsuite/gcc.target/aarch64/spellcheck_3.c
+++ b/gcc/testsuite/gcc.target/aarch64/spellcheck_3.c
@@ -4,6 +4,6 @@ __attribute__((target ("tune=cortex-a57-typo"))) void
 foo ()
 {
   /* { dg-message "valid arguments are: \[^\n\r]*; did you mean 'cortex-a57'?"  "" { target *-*-* } .-1 } */
-  /* { dg-error "invalid name \\(\"cortex-a57-typo\"\\) in 'target\\(\"tune=\"\\)' pragma or attribute"  "" { target *-*-* } .-2 } */
+  /* { dg-error "invalid name \\('cortex-a57-typo'\\) in 'target\\(\"tune=\"\\)' pragma or attribute"  "" { target *-*-* } .-2 } */
   /* { dg-error "pragma or attribute 'target\\(\"tune=cortex-a57-typo\"\\)' is not valid"  "" { target *-*-* } .-3 } */
 }
diff --git a/gcc/testsuite/gcc.target/aarch64/spellcheck_7.c b/gcc/testsuite/gcc.target/aarch64/spellcheck_7.c
index 1d31950cb61..1e1cbec057f 100644
--- a/gcc/testsuite/gcc.target/aarch64/spellcheck_7.c
+++ b/gcc/testsuite/gcc.target/aarch64/spellcheck_7.c
@@ -9,4 +9,4 @@ foo ()
 }
 
 /* { dg-error "invalid feature modifier .typo. in .-march=armv8-a\\+typo."  "" { target *-*-* } 0 } */
-/* { dg-message "valid arguments are: \[^\n\r]*;'?"  "" { target *-*-* } 0 } */
+/* { dg-message "valid arguments are: \[^\n\r]*"  "" { target *-*-* } 0 } */

Re: [committed] aarch64: Adjust spellcheck tests for recent quotation-mark changes

[Martin Liška]

On 1/21/22 12:39, Richard Earnshaw wrote:
> Martin's recent change to the way we handle quotation marks and
> punctuation in error messages caused some fallout in the testsuite.
> This patch updates the tests for the new output.

Thank you for the patch.

Martin