Re: [Committed] Use special-purpose hash table to speed up walk_tree

[Mark Mitchell <mark@codesourcery.com>]

Steven Bosscher wrote:
> On Saturday 16 October 2004 11:47, Jakub Jelinek wrote:
> 
>>But on x86-64-redhat-linux essentially makes even bootstrap impossible
>>(well, I have killed it after it spent more than 10 minutes compiling
>>insn-recog or insn-attrtab by stage1/cc1).
>>hash1's distribution is less than perfect.

In that case, go ahed and revert the patch.  I know that we normally 
require a 48-hour period, but I know Matt, and I am confident that he 
will not complain.

Then, Matt will work out how to fix it.

> It would have been nice if this patch had been tested better.  Good
> for you, 2% on QT, but what are the effects on other code?  And are
> we in stage3 now or not?  I did not see this idea on Mark's list of
> things that would be allowed in.

There is an item for improving compile-time performance; this falls 
under that.

> And why did Mark approve this offline, isn't it the policy that a
> patch is posted to gcc-patches and reviewed in public?

I don't think there is any such policy one way or the other.  Certainly, 
there is precedent for patches being approved offline.  Matt sent me the 
patch, and it looked good to me.  I didn't see any reason to test it on 
other architectures.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com