From: Bruce Korb <bkorb@veritas.com>
To: giovannibajo@libero.it
Cc: gcc-bugzilla@gcc.gnu.org, GCC-Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Bug target/16300] Bug in vendor /usr/include/net/if.h needs fixincluding
Date: Mon, 18 Oct 2004 06:23:00 -0000 [thread overview]
Message-ID: <41734D28.A5607C6A@veritas.com> (raw)
In-Reply-To: <20041016033011.24264.qmail@sourceware.org>
giovannibajo at libero dot it wrote:
>
> ------- Additional Comments From giovannibajo at libero dot it 2004-10-16 03:30 -------
> CC'ing also Bruce because he's the fixincludes maintainer. Bruce, BTW, as a
> developer which digs for the first time in fixincludes, let me say that
> fixincludes/README is not very clear about how 'make check' is supposed to work.
I can only fix things about which I get feedback so it incrementally
gets better. I'm sorry you found it difficult.
> Also, it does not explain if it is possible (and how) to use the test_text to
> verify the correctness of the fix. When I run 'make check' I don't understand
> if my new hack is being tested or not, and if it is correct or not.
"test-text" should contain one or more examples of broken text that
needs to be fixed. "make check" will spin a file with that text in it
and run the "fixinc" program, then run a recursive "diff" between the
patched files and a set of example files. Any differences are highlighted.
So, when you make a fix, you should pretty well understand how the
broken text ought to be transformed. In the "make check", you ought
to see a diff that includes that new transform in the new output and
not in the sample output.
> 4. Rebuild the compiler and check the header causing the issue.
> Make sure it is now properly handled. Add tests to the
> "test_text" entry(ies) that validate your fix. This will
> help ensure that future fixes won't negate your work.
That means first, ensure the header you want fixed is fixed.
Then, incorporate the brokenness in the "text-text" field.
Then, ensure it is fixed in the sample output.
Then, add the fixed result into the baseline sample files.
Finally:
> If you are having some problem with a system header that is either
> broken by the manufacturer, or is broken by the fixinclude process,
> then you will need to alter or add information to the include fix
> definitions file, ``inclhack.def''. Please also send relevant
> information to gcc-bugs@gcc.gnu.org, gcc-patches@gcc.gnu.org and,
> please, to me: bkorb@gnu.org.
That means send me email if you are still having problems.
Regards, Bruce
next parent reply other threads:[~2004-10-18 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040630163127.16300.skunk@iskunk.org>
[not found] ` <20041016033011.24264.qmail@sourceware.org>
2004-10-18 6:23 ` Bruce Korb [this message]
2004-10-18 13:38 ` Giovanni Bajo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41734D28.A5607C6A@veritas.com \
--to=bkorb@veritas.com \
--cc=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=giovannibajo@libero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).