From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24556 invoked by alias); 18 Oct 2004 05:06:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24524 invoked from network); 18 Oct 2004 05:06:00 -0000 Received: from unknown (HELO MTVMIME03.enterprise.veritas.com) (143.127.3.10) by sourceware.org with SMTP; 18 Oct 2004 05:06:00 -0000 Received: from megami.veritas.com (unverified) by MTVMIME03.enterprise.veritas.com (Content Technologies SMTPRS 4.3.12) with SMTP id ; Sun, 17 Oct 2004 22:05:57 -0700 Received: from bach.veritas.com ([172.22.12.213]) (3144 bytes) by megami.veritas.com via sendmail with P:esmtp/R:smart_host/T:smtp (sender: ) id for ; Sun, 17 Oct 2004 22:05:57 -0700 (PDT) (Smail-3.2.0.101 1997-Dec-17 #15 built 2001-Aug-30) Received: from veritas.com (unknown [127.0.0.1]) by bach.veritas.com (Postfix) with ESMTP id DB81F75810D; Mon, 18 Oct 2004 00:57:12 -0400 (EDT) Message-ID: <41734D28.A5607C6A@veritas.com> Date: Mon, 18 Oct 2004 06:23:00 -0000 From: Bruce Korb Organization: Home MIME-Version: 1.0 To: giovannibajo@libero.it Cc: gcc-bugzilla@gcc.gnu.org, GCC-Patches Subject: Re: [Bug target/16300] Bug in vendor /usr/include/net/if.h needs fixincluding References: <20040630163127.16300.skunk@iskunk.org> <20041016033011.24264.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg01452.txt.bz2 giovannibajo at libero dot it wrote: > > ------- Additional Comments From giovannibajo at libero dot it 2004-10-16 03:30 ------- > CC'ing also Bruce because he's the fixincludes maintainer. Bruce, BTW, as a > developer which digs for the first time in fixincludes, let me say that > fixincludes/README is not very clear about how 'make check' is supposed to work. I can only fix things about which I get feedback so it incrementally gets better. I'm sorry you found it difficult. > Also, it does not explain if it is possible (and how) to use the test_text to > verify the correctness of the fix. When I run 'make check' I don't understand > if my new hack is being tested or not, and if it is correct or not. "test-text" should contain one or more examples of broken text that needs to be fixed. "make check" will spin a file with that text in it and run the "fixinc" program, then run a recursive "diff" between the patched files and a set of example files. Any differences are highlighted. So, when you make a fix, you should pretty well understand how the broken text ought to be transformed. In the "make check", you ought to see a diff that includes that new transform in the new output and not in the sample output. > 4. Rebuild the compiler and check the header causing the issue. > Make sure it is now properly handled. Add tests to the > "test_text" entry(ies) that validate your fix. This will > help ensure that future fixes won't negate your work. That means first, ensure the header you want fixed is fixed. Then, incorporate the brokenness in the "text-text" field. Then, ensure it is fixed in the sample output. Then, add the fixed result into the baseline sample files. Finally: > If you are having some problem with a system header that is either > broken by the manufacturer, or is broken by the fixinclude process, > then you will need to alter or add information to the include fix > definitions file, ``inclhack.def''. Please also send relevant > information to gcc-bugs@gcc.gnu.org, gcc-patches@gcc.gnu.org and, > please, to me: bkorb@gnu.org. That means send me email if you are still having problems. Regards, Bruce