public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Aaron W. LaFramboise" <aaronavay62@aaronwl.com>
To: DJ Delorie <dj@redhat.com>
Cc: gcc-patches@gcc.gnu.org, gp@qnx.com, ericw@evcohs.com
Subject: Re: [PING] Windows patches.
Date: Mon, 25 Oct 2004 20:03:00 -0000	[thread overview]
Message-ID: <417D5207.7080604@aaronwl.com> (raw)
In-Reply-To: <200410251858.i9PIw8tQ025887@greed.delorie.com>

DJ Delorie wrote:
>>The first patch disables building fixincludes for targets where it
>>is not needed.  This was done previously, but got lost in the
>>fixincludes transition to toplevel.  It needs a configury
>>maintainer.
> 
> Target-specific changes in configury are normally approved by the
> target maintainers, not the configury maintainers, as only the target
> maintainers know if the change is correct.

(The patch was <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg00934.html>.)

This patch affects:
  alpha*-*-*vms*
  arm-semi-aof
  hppa1.1-*-osf*
  hppa1.1-*-bsd*, i370-*-opened*
  i[[3456789]]86-*-mingw32*
  *-*-cygwin*
  i[[3456789]]86-moss-msdos
  i[[3456789]]86-*-moss*
  i[[3456789]]86-*-pe
  powerpc-*-eabi
  powerpcle-*-eabi*
  powerpc-*-rtems*

QNX and AVR targets have indicated also that they don't want fixincludes.

For these targets, this patch restores the behavior of fixincludes
builds before it was moved to toplevel.

Does the patch really need to be signed off by all of these maintainers?
 Unless since fixincludes moved to toplevel one of these targets added
fixincludes rules, which is unlikely, there will be no change in
functionality , except for shorter build times, and perhaps the
difference between a currently broken build and a working build.

Aaron W. LaFramboise

  reply	other threads:[~2004-10-25 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-23 21:58 Aaron W. LaFramboise
2004-10-24  0:33 ` Tom Tromey
2004-10-25 22:10   ` Aaron W. LaFramboise
2004-10-26 15:42     ` Tom Tromey
2004-10-25 19:19 ` DJ Delorie
2004-10-25 20:03   ` Aaron W. LaFramboise [this message]
2004-10-25 20:25     ` DJ Delorie
2004-10-25 21:12     ` E. Weddington
2004-11-05 19:10 ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=417D5207.7080604@aaronwl.com \
    --to=aaronavay62@aaronwl.com \
    --cc=dj@redhat.com \
    --cc=ericw@evcohs.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gp@qnx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).