From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 881F23858D3C for ; Mon, 17 Oct 2022 07:37:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 881F23858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,190,1661846400"; d="scan'208";a="84861624" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 16 Oct 2022 23:37:06 -0800 IronPort-SDR: pUFozXLOvS6EaTlvIKAIEHZ27X+Hx3sHG9x6Tj3wOdUZzwvcOU/daVv/ndkIILIo8m6deWcjy9 MbRYz/6PEkERUB5OK4x8A3H+0zbHmbf4PbuLU2JKDpAmh8U1Kas8eNVasesielXkY5nju46Ina hA0+NYzWxXzoTK+1uSCPE1QsHlfXmAlYg4xpP5gyYiLPHbR+EqtL4/AdbhWwRKb1IJdrx0LpWC Gz2UVsXVw9VKbdS/Vs30LIvQVbuDJlbaQv2t1zZQjqeX/qB6G5W8x2GTLadPWeaiNO3wQU0r9m N5U= Message-ID: <419bf239-6672-8d64-e3e3-bfe3196f7878@codesourcery.com> Date: Mon, 17 Oct 2022 09:36:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: *ping* / Re: [Patch] libgomp: Add offload_device_gcn check, add requires-4a.c test Content-Language: en-US From: Tobias Burnus To: gcc-patches , Jakub Jelinek , Andrew Stubbs CC: "Vollweiler, Marcel" References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12.10.22 16:05, Tobias Burnus wrote: > This came up because the USM implementation with > -foffload-memory=3D{unified,pinned} > as posted at > https://gcc.gnu.org/pipermail/gcc-patches/2022-July/597976.html > does not handle USM with static variables. > > This shows up for the OG12 alias devel/omp/gcc-12 branch as FAIL for > requires-4.c. > > The attached patch prepares for skipping requires-4.c for the > gcn/nvptx device > and adds an adjacent requires-4a.c testcase, using heap memory, that > can still > run on gcn/nvptx. > > Additionally, I commented on no longer used #defined, following the > precedence GOMP_DEVICE_HOST_NONSHM. > > Thus, this tests adds another testcase and one effective-target check, > out-comments a unused #define - and that's it. > (Otherwise, it is just a prep patch.) > > OK for mainline? > > Tobias > > PS: Currently, neither the preexisting offload_device_nvptx nor the new > offload_device_gcn target selector is used, neither in old code nor by > this patch. ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955