From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 0616E3858000 for ; Fri, 10 Nov 2023 03:49:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0616E3858000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0616E3858000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699588200; cv=none; b=Tz8yU02WQNIBouylA5Pm8mFU/3bfu6SgIaqNHTHlDBH092FR77VKFIw99Q9Cb5U6b82RRxAEpMcBv2MujTcPvvAWWuTmHeCP1cyC+k45MejvCZQ+FzQpuvWvkX241dLeOP4OaepCJrxW7o5TEdQKDWezYiTUxoPZI1iZS3ZhMK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699588200; c=relaxed/simple; bh=H9/R4ezELcYRuF7cXS1iVyMPriS/p0MH3buSIrC67ig=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=J0z++dBcvpD89s63PdF10aEDLQJ+hRMNqr8sUV8vEB9sVEwb+60z626r4/YIjUIjJF8CxQwaXthPp3tZ5L73bOXgX3G2xuus7L0zF5liHGOYUXpToed/WWQN1IZLwx8+O+P0+WEavk/ulelJDK6cB4Td4ynOj1cd/qkK5/u5sKY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7a9857c14c5so56802239f.3 for ; Thu, 09 Nov 2023 19:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699588198; x=1700192998; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hU9FukL5u3V40XY4zFhsNKceBbOpUpQ1jpQgNeZbaSg=; b=FDSuO9VubBzFtIoS8E8g1dWT0yaF2DyrzwhqffWpk6syH47sXqO4WQZOsGlCzu4c4D yUWbesH8T4HweXI/w0dMXwAsDfWWhl2HC7yWJHTN7k3dlhWacy6oiPT7yzvPJ8so4rUq MZiFViNmhORqMgnbWKfyFfF686N3W3fQ79FM7Aknj265IvIzuGgE54pan/zKtdxYUo7Q 45xq13JauJstlxVv+WOFPLQVyCrZ5L3c9wsJjWDO0rPbzFFYgKoY8WX1+U6tk/fNU8ul Qmdnw/iecKWlB97WabgjoE8owIoJWZ0RnVQoWGxckvu084LZXDB0hQsXDWtnhQxFLIdt KOpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699588198; x=1700192998; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hU9FukL5u3V40XY4zFhsNKceBbOpUpQ1jpQgNeZbaSg=; b=KIVHA1Bg6BiegYSDwlDLJfoISk9Bk8IsvHM955C05M51OKKDmc5o8AEGKzoQ4Td6pc 3sTNKqW9ctfsDtNw6xtEvSr/iRiclQckUPM+GUvyRkC/iHE9gJulZexxQ/B6IdJ9e9nG PacDK42syO1jc2ZfF0P4U7W9VTd8kMUVPYJkBle0/1lOAb+J/hHRYvEtZ/HrfeOPaCuZ IJ3QJ/tOn8oAf4EtahTmNKSz8BIuuaZQloR3M13M34FZz6fyIJRUtzwvn3wIA2iaBJHc vZN799sz5dvtV4CbLnKuHTvLft05VPfa1fG3CQ/reazDztC87SyyNtmMTD6EG6tCvwXh la9w== X-Gm-Message-State: AOJu0YyY7KMPDpL1rX3RXPepRj1WZvZ/mSRvY9MOxSpDd8UDN799r34A 87eYelMaxRUSwQ9iYP0cU2s= X-Google-Smtp-Source: AGHT+IEnpCfqlqSn20S2eAivGUW37PQfV1V35+oPXY+lVV11EOkvCLMoNRMBKxDxCohDenCDnuR/4g== X-Received: by 2002:a5d:870a:0:b0:7aa:125a:b0c4 with SMTP id u10-20020a5d870a000000b007aa125ab0c4mr4337091iom.5.1699588198196; Thu, 09 Nov 2023 19:49:58 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id o1-20020a056602124100b007a669ac1ef4sm4411847iou.40.2023.11.09.19.49.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 19:49:57 -0800 (PST) Message-ID: <41a4d065-c4b6-4a67-adf0-e84e942616c7@gmail.com> Date: Thu, 9 Nov 2023 20:49:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273] Content-Language: en-US To: "Kewen.Lin" , Alexander Monakov , Maxim Kuvyrkov Cc: GCC Patches , Richard Guenther , Richard Sandiford , Jeff Law , Vladimir Makarov , zhroma@ispras.ru, Andrey Belevantsev , Segher Boessenkool , Peter Bergner , Michael Meissner References: <85b4098e-a72f-d013-ff17-8097971f71ba@linux.ibm.com> <09FEFDAE-698B-4B06-A896-8088B9B31539@linaro.org> <4675c26c-f230-b6d6-27c5-bc9f74736e38@linux.ibm.com> From: Jeff Law In-Reply-To: <4675c26c-f230-b6d6-27c5-bc9f74736e38@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/23 18:57, Kewen.Lin wrote: > Hi Maxim and Alexander, > > Thanks a lot for the review comments! > > on 2023/11/10 01:40, Alexander Monakov wrote: >> >> On Thu, 9 Nov 2023, Maxim Kuvyrkov wrote: >> >>> Hi Kewen, >>> >>> Below are my comments. I don't want to override Alexander's review, and if >>> the patch looks good to him, it's fine to ignore my concerns. >>> >>> My main concern is that this adds a new entity -- forceful skipping of >>> DEBUG_INSN-only basic blocks -- to the scheduler for a somewhat minor change >>> in behavior. Unlike NOTEs and LABELs, DEBUG_INSNs are INSNS, and there is >>> already quite a bit of logic in the scheduler to skip them _as part of normal >>> operation_. > > Yeah, I noticed that the scheduler takes care of DEBUG_INSNs as normal operations. > When I started to work on this issue, initially I wanted to try something similar > to your idea #2, but when checking the APIs, I realized why not just skip the basic > block with NOTEs and LABELs, DEBUG_INSNs as well. IMHO there is no value to try to > schedule this kind of BB (to be scheduled range), skipping it can save some resource > allocation (like block dependencies) and make it more efficient (not enter function > schedule_block etc.), from this perspective it seems an enhancement. Does it sound > reasonable to you? It sounds reasonable, but only if doing so doesn't add significant implementation complexity. ie, the gains from doing less work here are likely to be very marginal, so I'm more interested in clean, easy to maintain code. Jeff