From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) by sourceware.org (Postfix) with ESMTPS id 2557A3858D1E for ; Sat, 24 Dec 2022 00:10:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2557A3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pfeifer.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pfeifer.com Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id A4A0B33E95; Fri, 23 Dec 2022 19:10:16 -0500 (EST) Received: from naga.localdomain (62-47-241-209.adsl.highway.telekom.at [62.47.241.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id C910A33EAA; Fri, 23 Dec 2022 19:10:15 -0500 (EST) Date: Sat, 24 Dec 2022 01:10:13 +0100 (CET) From: Gerald Pfeifer To: Iain Buclaw , Andreas Tobler cc: gcc-patches@gcc.gnu.org, Lorenzo Salvadore Subject: Re: Ping^2: [PATCH] d: Update __FreeBSD_version values [PR107469] In-Reply-To: Message-ID: <41bda69b-070c-cd69-eecc-b63e4aade5b1@pfeifer.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.10 on 209.68.5.143 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ian (and Andreas), On Wed, 14 Dec 2022, Lorenzo Salvadore wrote: > Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html > > I would like to remind that Gerald Pfeifer already volunteered to commit > this patch when it is approved. However the patch has not been approved > yet. I am tempted to commit this under our obvious rule (and this has been part of the FreeBSD ports for weeks now). It still would be preferable to get your review (and approval ideally ;-), though. Would you mind having a look? (Andreas, any take as GCC's FreeBSD maintainer?) Thanks, Gerald >> ------- Original Message ------- >> On Friday, November 11th, 2022 at 12:07 AM, Lorenzo Salvadore developer@lorenzosalvadore.it wrote: >> >>> Update __FreeBSD_version values for the latest FreeBSD supported >>> versions. In particular, add __FreeBSD_version for FreeBSD 14, which is >>> necessary to compile libphobos successfully on FreeBSD 14. >>> >>> The patch has already been applied successfully in the official FreeBSD >>> ports tree for the ports lang/gcc11 and lang/gcc11-devel. Please see the >>> following commits: >>> >>> https://cgit.freebsd.org/ports/commit/?id=f61fb49b2e76fd4f7a5b7a11510b5109206c19f2 >>> https://cgit.freebsd.org/ports/commit/?id=57936dba89ea208e5dbc1bd2d7fda3d29a1838b3 >>> >>> libphobos/ChangeLog: >>> >>> 2022-11-10 Lorenzo Salvadore developer@lorenzosalvadore.it >>> >>> PR d/107469. >>> * libdruntime/core/sys/freebsd/config.d: Update __FreeBSD_version. >>> >>> --- >>> libphobos/libdruntime/core/sys/freebsd/config.d | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/libphobos/libdruntime/core/sys/freebsd/config.d b/libphobos/libdruntime/core/sys/freebsd/config.d >>> index 5e3129e2422..9d502e52e32 100644 >>> --- a/libphobos/libdruntime/core/sys/freebsd/config.d >>> +++ b/libphobos/libdruntime/core/sys/freebsd/config.d >>> @@ -14,8 +14,9 @@ public import core.sys.posix.config; >>> // NOTE: When adding newer versions of FreeBSD, verify all current versioned >>> // bindings are still compatible with the release. >>> >>> - version (FreeBSD_13) enum __FreeBSD_version = 1300000; >>> -else version (FreeBSD_12) enum __FreeBSD_version = 1202000; >>> + version (FreeBSD_14) enum __FreeBSD_version = 1400000; >>> +else version (FreeBSD_13) enum __FreeBSD_version = 1301000; >>> +else version (FreeBSD_12) enum __FreeBSD_version = 1203000; >>> else version (FreeBSD_11) enum __FreeBSD_version = 1104000; >>> else version (FreeBSD_10) enum __FreeBSD_version = 1004000; >>> else version (FreeBSD_9) enum __FreeBSD_version = 903000; >>> -- >>> 2.38.0