From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83694 invoked by alias); 30 Jun 2017 09:24:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83526 invoked by uid 89); 30 Jun 2017 09:24:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=predict, story, family, HContent-Transfer-Encoding:8bit X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jun 2017 09:24:38 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 24191AAB9; Fri, 30 Jun 2017 09:24:21 +0000 (UTC) Subject: Re: [PATCH 4/N] Recover GOTO predictor. To: Richard Biener Cc: GCC Patches , Jan Hubicka , ppalka@gcc.gnu.org References: <8541efc0-91ff-f5f2-0c07-b6e4f35af41c@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <41cf59a8-bc36-647c-618a-9eda7afac084@suse.cz> Date: Fri, 30 Jun 2017 09:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg02366.txt.bz2 PING^1 Can you please Honza give a formal approval for the patch? Thanks, Martin On 06/22/2017 01:47 PM, Richard Biener wrote: > On Thu, Jun 22, 2017 at 12:57 PM, Martin Liška wrote: >> On 06/22/2017 12:27 PM, Richard Biener wrote: >>> On Wed, Jun 21, 2017 at 3:06 PM, Martin Liška wrote: >>>> Hello. >>>> >>>> There's one additional predictor enhancement that is GOTO predict that >>>> used to working. Following patch adds expect statement for C and C++ family >>>> languages. >>>> >>>> There's one fallout which is vrp24.c test-case, where only 'Simplified relational' >>>> appears just once. Adding Richi and Patrick who can probably help how to fix the >>>> test-case. >>> >>> Happens to be optimized better now, there's only one predicate to simplify >>> left in the IL input to VRP1. I suggest to change it to match 1 times and add >>> -fdump-tree-optimized to dg-options and >>> >>> /* { dg-final { scan-tree-dump-times "if " 3 "optimized" } } */ >>> >>> to verify we have 3 conditions left. >> >> Thanks for help. >> What about the comment: >> >> /* The first n_sets > 0 test can be simplfiied into n_sets == 1 since >> n_sets can only have the values [0, 1] as it's the result of a >> boolean operation. >> >> The second n_sets > 0 test can also be simplified into n_sets == 1 >> as the only way to reach the tests is when n_sets <= 1 and the only >> value which satisfies both conditions is n_sets == 1. */ >> >> I guess just only one can be valid? Or is it a different story now? > > The 2nd one is handled by earlier jump-threading. > >> Martin >> >>> >>>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. >>>> >>>> Ready to be installed? >>>> Martin >>