On 29-11-18 19:17, Ian Lance Taylor wrote: > On Thu, Nov 29, 2018 at 4:33 AM, Tom de Vries wrote: >> On 29-11-18 00:26, Ian Lance Taylor wrote: >>> On Wed, Nov 28, 2018 at 3:15 PM, Tom de Vries wrote: >>>> >>>> this patch factors out new function backtrace_vector_free. >>>> >>>> Bootstrapped and reg-tested on x86_64. >>>> >>>> OK for trunk? >>> >>> We should only add new files if we really absolutely must, as this >>> package is copied around to a lot of places (e.g., >>> libsanitizer/libbacktrace) and adding files here requires >>> modifications in all those places. >>> >> >> I see, thanks for the explanation. >> >> How about his patch? It does not add a file, though it does add an >> external function which requires a rename in libsanitizer/libbacktrace >> (I don't know whether that requires changes in any other places). >> >> [ Also, it inlines backtrace-vector.c into alloc.c and mmap.c, so it >> duplicates code. If that is not acceptable, I could move it to >> internal.h as static inline or static ATTRIBUTE_UNUSED. ] > > Yes, let's just use a static inline function or a macro. Thanks. Committed as static inline. Thanks, - Tom