From: Joseph Myers <joseph@codesourcery.com>
To: Richard Biener <rguenther@suse.de>
Cc: <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH 2/2] Remove Negative(gwarf-) from gdwarf
Date: Mon, 27 Mar 2023 22:18:35 +0000 [thread overview]
Message-ID: <4237b38d-2e8b-51a9-f2ea-c85f1eb79759@codesourcery.com> (raw)
In-Reply-To: <20230324102009.C79A5138F1@imap2.suse-dmz.suse.de>
On Fri, 24 Mar 2023, Richard Biener via Gcc-patches wrote:
> Prior to the removal of STABS support the gdwarf, gstabs, ... options
> formed a cycle with their Negative(..) option attribute. But that
> didn't actually have any effect since most of the options also
> are Joined or JoinedOrMissing for which there's no pruning of options
> and so once ran into the set_debug_level diagnostics reporting
> conflicting debug formats.
>
> The following removes the remains of that cycle, which is a
> Negative option from gdwarf to gdwarf-. With RejectNegative
> added the expected effect of -gdwarf-4 -gdwarf would be to
> enable DWARF5 support (but this doesn't happen for some reason).
> I think the more sensible behavior is that seen and implemented
> in opts.cc, the more specific -gdwarf-4 determines the DWARF level
> and a later or earlier -gdwarf becomes a no-op. So the
> Negative(..) annotation on gdwarf is just confusing.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, OK?
OK.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2023-03-27 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 10:20 Richard Biener
2023-03-27 22:18 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4237b38d-2e8b-51a9-f2ea-c85f1eb79759@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).