From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id E90AF3858C42 for ; Fri, 19 Jan 2024 09:55:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E90AF3858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E90AF3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=85.10.215.148 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705658142; cv=none; b=DcRxUd6p1WxBRjH8HEt5EnD/GM5rkBKYcv857uHXhxHCVCnP0RqXx97rrmHAdTEljEtGKjjOcdtgMPfwADR30+Fpa4JbYOY3ix5WEE63nopZzyUtft7Jxcp1iESNad9Ebq/I7/JBsLpRwex3Gy1hkia3JBKFmq2j2LcwlO9tHwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705658142; c=relaxed/simple; bh=I0GzlYp4TnwobVWLnyEjHYlvAQxG0Cz2x1fwrRn0TLA=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=ArZzX000i1yoC7DBoBnI7f/gOuh/h5iM3US/w/aP8//e1SW8qQEklWKU7ngYfPrQqDmcvTfOBvaTg81bNTXHFqX0xMjnCcRks6zDx2KrA+XaG06GNgpD9emOwUGPQCG355ekYgKT7Vs6wBarTJylBZJkTIXSajG4ng1/dBd0JZE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from sslproxy01.your-server.de ([78.46.139.224]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQlb7-000NJO-V6 for gcc-patches@gcc.gnu.org; Fri, 19 Jan 2024 10:55:37 +0100 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQlb7-000UIp-Rs for gcc-patches@gcc.gnu.org; Fri, 19 Jan 2024 10:55:37 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 8CE1748006C for ; Fri, 19 Jan 2024 10:55:37 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavis, port 10032) with ESMTP id ohkbJGnbmD9K for ; Fri, 19 Jan 2024 10:55:37 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 1F1C4480157 for ; Fri, 19 Jan 2024 10:55:37 +0100 (CET) X-Virus-Scanned: amavis at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavis, port 10026) with ESMTP id isz7azqAgue0 for ; Fri, 19 Jan 2024 10:55:37 +0100 (CET) Received: from [192.168.96.179] (unknown [192.168.96.179]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 0221D48006C for ; Fri, 19 Jan 2024 10:55:36 +0100 (CET) Message-ID: <4239bcab-2c13-4d2a-a35d-93e488f9a21f@embedded-brains.de> Date: Fri, 19 Jan 2024 10:55:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libgomp: Fix build for -fshort-enums Content-Language: en-US From: Sebastian Huber To: gcc-patches@gcc.gnu.org References: <20230522125149.30467-1-sebastian.huber@embedded-brains.de> <1831603b-b2cb-c736-72f1-df86d65443a5@embedded-brains.de> <60de3d0f-420a-424f-942a-3f6faa5263c9@embedded-brains.de> In-Reply-To: <60de3d0f-420a-424f-942a-3f6faa5263c9@embedded-brains.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldi-networks.de X-Virus-Scanned: Clear (ClamAV 0.103.10/27158/Thu Jan 18 10:41:33 2024) X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11.09.23 14:57, Sebastian Huber wrote: > On 04.07.23 08:20, Sebastian Huber wrote: >> On 22.05.23 14:51, Sebastian Huber wrote: >>> Make sure that the API enums have at least the size of int. =20 >>> Otherwise the >>> following build error may occur: >>> >>> In file included from gcc/libgomp/env.c:34: >>> ./libgomp_f.h: In function 'omp_check_defines': >>> ./libgomp_f.h:77:8: error: size of array 'test' is negative >>> =C2=A0=C2=A0=C2=A0 77 |=C2=A0=C2=A0 char test[(28 !=3D sizeof (omp_lo= ck_t) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 ^~~~ >>> >>> libgomp/ChangeLog: >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0* omp.h.in (omp_alloctrait_key_t):=C2=A0 Add = __omp_alloctrait_key_t_max__ >>> =C2=A0=C2=A0=C2=A0=C2=A0with a value of the int type maximum. >>> --- >>> =C2=A0 libgomp/omp.h.in | 3 ++- >>> =C2=A0 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/libgomp/omp.h.in b/libgomp/omp.h.in >>> index bd1286c2a3f..3b1612fcb15 100644 >>> --- a/libgomp/omp.h.in >>> +++ b/libgomp/omp.h.in >>> @@ -146,7 +146,8 @@ typedef enum omp_alloctrait_key_t >>> =C2=A0=C2=A0=C2=A0 omp_atk_fallback =3D 5, >>> =C2=A0=C2=A0=C2=A0 omp_atk_fb_data =3D 6, >>> =C2=A0=C2=A0=C2=A0 omp_atk_pinned =3D 7, >>> -=C2=A0 omp_atk_partition =3D 8 >>> +=C2=A0 omp_atk_partition =3D 8, >>> +=C2=A0 __omp_alloctrait_key_t_max__ =3D __INT_MAX__ >>> =C2=A0 } omp_alloctrait_key_t; >>> =C2=A0 typedef enum omp_alloctrait_value_t >> >> Could someone please have a look at this. >=20 > Ping. Any chance to get this integrated for GCC 14? --=20 embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/