From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 964CD3886C44 for ; Thu, 27 Oct 2022 07:26:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 964CD3886C44 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62b.google.com with SMTP id n12so2004630eja.11 for ; Thu, 27 Oct 2022 00:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=ETi0V1f/qAbCsKdSpYBqgrPUPbwIvSyLfOQrmHGgQBE=; b=kYBja8b9kEZnvS3OhKjyyhj9fJW/14QzrnKnoBJ7VtUhlaCGz1q0k+HKupgkfb/z90 I2g8f2NYpqVfkDgriNMfyS3Tbw0EFT8xERlHstb2WfisPIN7odZCfso8zebKOn5Ye2da nUHSGk01EHcdLRvjlJ1EFuPQbBNjkrLXzEYjOVqLthV/lRU0Jp4y1A6a+UBGEbIsdLBS CwL+vrHZQgo3ZbZEeLFaqxo0PxLDg6V5WE0EW1VYMF71A1dPi5eMnNtufhjTQ2U6QaAs wtzG1N0uqfrtVCQjXxmEYWFSCgzk5X42Cm8eKcb0KMhr8okeaLxptsBlpNsgyR8UAG1H f52A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ETi0V1f/qAbCsKdSpYBqgrPUPbwIvSyLfOQrmHGgQBE=; b=Tw9pKYvJwN7MWTR0HVDHYyAXaiA+Ra3D9jr+jH2Thh5Nr7S1G0MGuXL3B25juw6Mxj KRlh4jjuXPnfkZjCczVA6/lUwuYFcDvy/yLkrP4nqkju5lbU0KfIJpIsrsMHwoAabWsS 3p2rqR4UFCZ7vaSOeHbS4HxMl+981zgAHEFGegszRZGlKpOKFOgKxVI0GZRklUKkjz18 26HNvQi4Up5iK9H+21Q7AhXLSB/oLWX/CXkZGNcXX0zL0tA4b0gVDkzmEua0DyYDhv5n ZLweJV1BlhNmEC/2YYb4m1Z81jvQBO78u9FMAdaqA0FRBmE3e7uDnCsRNnynoJZ0Gz85 Zg3Q== X-Gm-Message-State: ACrzQf2OSX+mYpYtakjGgIb1nIEg7iigBnBieDvVH2jmKAM9ZtL3fF0/ 2cE7/o+f30kbd6fQSi5hIDM= X-Google-Smtp-Source: AMsMyM501RdSP3Q80vXPxIQfl4w6mjVDsJICQxjKAl7NXOnGU1Bq21xBq8CJHrnrWHxsq1t69M6RLw== X-Received: by 2002:a17:906:cc0b:b0:78e:1d51:36ea with SMTP id ml11-20020a170906cc0b00b0078e1d5136eamr41555444ejb.408.1666855593040; Thu, 27 Oct 2022 00:26:33 -0700 (PDT) Received: from smtpclient.apple ([2a02:3038:201:4653:d35:28a9:915b:5e9a]) by smtp.gmail.com with ESMTPSA id my42-20020a1709065a6a00b007a0b28c324dsm336299ejc.126.2022.10.27.00.26.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 00:26:31 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] testsuite: Adjust vect-bitfield-read-* with vect_shift and vect_long_long [PR107240] Date: Thu, 27 Oct 2022 09:26:20 +0200 Message-Id: <423CD484-A554-4CBA-9374-53461D8AE0A6@gmail.com> References: Cc: GCC Patches , Richard Sandiford , "Andre Vieira (lists)" , Segher Boessenkool , Peter Bergner In-Reply-To: To: "Kewen.Lin" X-Mailer: iPhone Mail (20B82) X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 27.10.2022 um 09:10 schrieb Kewen.Lin : >=20 > =EF=BB=BFHi, >=20 > The test cases vect-bitfield-read-* requires vector shift > target support, they need one explicit vect_shift effective > target requirement checking. Besides, the vectype for struct > in test cases vect-bitfield-read-{2,4} is vector of long long, > we need to check effective target vect_long_long for them. > This patch can help to fix remaining vect-bitfield-* test > failures on powerpc. >=20 > Tested on powerpc64-linux-gnu P7 and P8, as well as > powerpc64le-linux-gnu P9 and P10. >=20 > Is it ok for trunk? Ok Thanks, Richard=20 > BR, > Kewen > ----- > PR testsuite/107240 >=20 > gcc/testsuite/ChangeLog: >=20 > * gcc.dg/vect/vect-bitfield-read-1.c: Add effective target checking > vect_shift. > * gcc.dg/vect/vect-bitfield-read-3.c: Likewise. > * gcc.dg/vect/vect-bitfield-read-5.c: Likewise. > * gcc.dg/vect/vect-bitfield-read-6.c: Likewise. > * gcc.dg/vect/vect-bitfield-read-7.c: Likewise. > * gcc.dg/vect/vect-bitfield-read-2.c: Add effective target checking > vect_shift and replace vect_int with vect_long_long. > * gcc.dg/vect/vect-bitfield-read-4.c: Likewise. > --- > gcc/testsuite/gcc.dg/vect/vect-bitfield-read-1.c | 1 + > gcc/testsuite/gcc.dg/vect/vect-bitfield-read-2.c | 3 ++- > gcc/testsuite/gcc.dg/vect/vect-bitfield-read-3.c | 1 + > gcc/testsuite/gcc.dg/vect/vect-bitfield-read-4.c | 3 ++- > gcc/testsuite/gcc.dg/vect/vect-bitfield-read-5.c | 1 + > gcc/testsuite/gcc.dg/vect/vect-bitfield-read-6.c | 1 + > gcc/testsuite/gcc.dg/vect/vect-bitfield-read-7.c | 1 + > 7 files changed, 9 insertions(+), 2 deletions(-) >=20 > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-1.c b/gcc/testsu= ite/gcc.dg/vect/vect-bitfield-read-1.c > index 01cf34fb444..42e50d9f0c8 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-1.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-1.c > @@ -1,4 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > +/* { dg-require-effective-target vect_shift } */ >=20 > #include > #include "tree-vect.h" > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-2.c b/gcc/testsu= ite/gcc.dg/vect/vect-bitfield-read-2.c > index 1a4a1579c14..a9aeefcd72c 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-2.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-2.c > @@ -1,4 +1,5 @@ > -/* { dg-require-effective-target vect_int } */ > +/* { dg-require-effective-target vect_shift } */ > +/* { dg-require-effective-target vect_long_long } */ >=20 > #include > #include "tree-vect.h" > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-3.c b/gcc/testsu= ite/gcc.dg/vect/vect-bitfield-read-3.c > index 849f4a017e1..c7d0fd26bad 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-3.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-3.c > @@ -1,4 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > +/* { dg-require-effective-target vect_shift } */ >=20 > #include > #include "tree-vect.h" > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-4.c b/gcc/testsu= ite/gcc.dg/vect/vect-bitfield-read-4.c > index 5bc9c412e96..6a3ed8c0c6f 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-4.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-4.c > @@ -1,4 +1,5 @@ > -/* { dg-require-effective-target vect_int } */ > +/* { dg-require-effective-target vect_shift } */ > +/* { dg-require-effective-target vect_long_long } */ >=20 > #include > #include "tree-vect.h" > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-5.c b/gcc/testsu= ite/gcc.dg/vect/vect-bitfield-read-5.c > index 1dc24d3eded..b2889df8a0a 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-5.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-5.c > @@ -1,4 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > +/* { dg-require-effective-target vect_shift } */ >=20 > #include > #include "tree-vect.h" > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-6.c b/gcc/testsu= ite/gcc.dg/vect/vect-bitfield-read-6.c > index 7d24c299758..2445f531be2 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-6.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-6.c > @@ -1,4 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > +/* { dg-require-effective-target vect_shift } */ >=20 > #include > #include "tree-vect.h" > diff --git a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-7.c b/gcc/testsu= ite/gcc.dg/vect/vect-bitfield-read-7.c > index 3b505db2bd3..4b1ec8a6dab 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-7.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-bitfield-read-7.c > @@ -1,4 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > +/* { dg-require-effective-target vect_shift } */ >=20 > #include > #include "tree-vect.h" > -- > 2.27.0